1713956 - Optimize the stop-to-reload and reload-to-stop animations

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Sam Foster [:sfoster] (he/him)]

The use of masks in the filmstrip SVGs we use for the reload/stop animations was identified as a possible cause of bug 1706333. The masks use simple paths - no opacity effects - so it should be possible to convert these to clip-paths.

We can also potentially use the pause technique from bug 1709173 to eliminate some of the duplicate frames here.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1713956 - Swap animation names and filenames so reload-to-stop animates from reload to stop icon, and stop-to-reload animates from stop to reload. r?jaws

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1713956 - Update stop-to-reload and reload-to-stop animations to use clip-paths vs. masks and pause key-frames rather than redundant svg frames. r?jaws

Depends on D117053

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8334d06908a
Swap animation names and filenames so reload-to-stop animates from reload to stop icon, and stop-to-reload animates from stop to reload. r=jaws
https://hg.mozilla.org/integration/autoland/rev/8c88597448d2
Update stop-to-reload and reload-to-stop animations to use clip-paths vs. masks and pause key-frames rather than redundant svg frames. r=jaws

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c8334d06908a
https://hg.mozilla.org/mozilla-central/rev/8c88597448d2

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing Bug 1715609

backout: https://hg.mozilla.org/integration/autoland/rev/f4c6e39c5f6bd1eb76abce8d43468f32f342752d

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/f4c6e39c5f6b

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e7068a2b6ae
Swap animation names and filenames so reload-to-stop animates from reload to stop icon, and stop-to-reload animates from stop to reload. r=jaws
https://hg.mozilla.org/integration/autoland/rev/01b9fd516f4d
Update stop-to-reload and reload-to-stop animations to use clip-paths vs. masks and pause key-frames rather than redundant svg frames. r=jaws

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7e7068a2b6ae
https://hg.mozilla.org/mozilla-central/rev/01b9fd516f4d