Closed Bug 1714012 Opened 3 years ago Closed 3 years ago

Proton: incostistent size of tab controls ("mute/unmute" 16x16px vs "close (x)" 24x24px)

Categories

(Firefox :: Tabbed Browser, defect)

Firefox 89
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: bugzilla, Unassigned)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1714011 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Upgraded to Firefox 89

Actual results:

Mute/Unmute tab control ("volume" icon) size is less than tab close control ("x" icon). This issue makes audio control button inconvenient to use.

Clickable areas:

  1. Mute/Unmute control ("volume" icon): 16x16 px
  2. Tab close button ("x" icon): 24x24px

Tab control sizes are incostistent.

Expected results:
Mute/unmute ("volume" icon) and Close tab ("x" icon) have the same clickable area size (24px+)

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Tabbed Browser

Thanks for filing. We made some changes during Proton development to make the clickable area of the close button bigger. Doing so also introduced some awkwardness if the tab title extends close to the close button. The tab close button is one of the most clicked on buttons in the browser UI so it was important that we made the task very easy to perform and we were okay with the awkwardness due to its high use.

The mute icon isn't used anywhere near as much and as such I don't think we would accept similar awkwardness when hovering it. We still want the favicon and tab title to fit together nicely. If we had to introduce more spacing around the mute icon, we would lose some of that nice fit of the design. I'm afraid that there isn't much we can do here and so I'm inclined to close this as invalid given that the implementation is per the design.

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)

If we had to introduce more spacing around the mute icon, we would lose some of that nice fit of the design

You don't even need to add any spacing here
https://i114.fastpic.ru/big/2021/0603/60/6d9caee7a120064b9311e2ff207c0360.png

Attached image Untitled.png

If we had to introduce more spacing around the mute icon
You dont have to, Jared. Check out the screenshot

Flags: needinfo?(jaws)

Hm, that's true. Though favicons are displayed at 16x16 so the switch from favicon to audio icon could be awkward as the audio icon would be noticeably bigger than the favicon it replaced.

Flags: needinfo?(jaws)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: