1714115 - Apply fix from bug 1706261 to the libwebrtc import from bug 1654112

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Comment 1

[Landry Breuil (:gaston)]

afaict the problem shown in bug 1706261 is still valid with newer webrtc so https://phabricator.services.mozilla.com/D116746 should be reapplied to https://searchfox.org/mozilla-central/source/third_party/libwebrtc/rtc_base/platform_thread.cc#187 in beta & m-c ?

Comment 2

[Landry Breuil (:gaston)]

[Tracking Requested - why for this release]: reapply the fix from bug #1706261 after bug #1654112 that landed for 96

Comment 3

[Landry Breuil (:gaston)]

Attachment: bug-1714115.diff

Comment 4

[Landry Breuil (:gaston)]

attachment backports/reapplies https://phabricator.services.mozilla.com/D116746 on top of the webrtc update.

Comment 5

[Byron Campen [:bwc]]

Let's see if I can just re-land that phabricator revision.

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=94bf3a83c99e3360e77553861d52a449b26cc631

Comment 7

[Byron Campen [:bwc]]

Attachment: Bug 1714115: Re-apply fix from bug 1706261 that was lost in bug 1654112. r?ng

Comment 8

[Byron Campen [:bwc]]

Unfortunately cannot simply re-land, since the file moved. Will need to go through the phabricator dance one more time.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d32376777978
Re-apply fix from bug 1706261 that was lost in bug 1654112. r=ng

Comment 10

[Landry Breuil (:gaston)]

thanks a lot !

Comment 11

[Dianna Smith [:diannaS]]

Not tracking this, but would take an uplift if it lands in time for 96.

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d32376777978

Comment 13

[Landry Breuil (:gaston)]

Comment on attachment 9256165 [details]
Bug 1714115: Re-apply fix from bug 1706261 that was lost in bug 1654112. r?ng

Beta/Release Uplift Approval Request

• User impact if declined: fix race conditions leading to tab crashes with multiple connecting webrtc clients (eg bug #1706261)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): not risky as it's been shipped to all users for the previous webrtc lifetime
• String changes made/needed: none

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9256165 [details]
Bug 1714115: Re-apply fix from bug 1706261 that was lost in bug 1654112. r?ng

Approved for 96.0b8

Comment 15

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0b81813cf2da