Closed Bug 171420 Opened 22 years ago Closed 22 years ago

faulty use of local variables in Flag.pm

Categories

(Bugzilla :: Attachments & Requests, defect)

Product:
Bugzilla
Component:
Attachments & Requests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.18

People

(Reporter: myk, Assigned: myk)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2: uses "Bugzilla::Config"
2.91 KB, patch
bbaetz
: review+
bbaetz
: review+
Details | Diff | Splinter Review 
Flag.pm uses $vars sometimes when it needs $::vars, and it contains a reference
to &Param that should be &::Param (which actually causes a software error).
Attached patch patch v1: fixes problems (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 101009 [details] [diff] [review]
patch v1: fixes problems

|use Bugzilla::Config| (and drop the &) and |use vars| instead

        Attachment #101009 -
        Flags: review-

    
    

    
  
*** Bug 171474 has been marked as a duplicate of this bug. ***

    
    

    
  


  

        Attachment #101009 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 101039 [details] [diff] [review]
patch v2: uses "Bugzilla::Config"

r=bbaetz x2

Long live Bugzilla::Template!

        Attachment #101039 -
        Flags: review+

    
    

    
  
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.2; previous revision: 1.1
done

Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
  
Blocks: rt-clean-up
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa

          You need to log in
          before you can comment on or make changes to this bug.