Closed
Bug 171420
Opened 23 years ago
Closed 23 years ago
faulty use of local variables in Flag.pm
Categories
(Bugzilla :: Attachments & Requests, defect)
Bugzilla
Attachments & Requests
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: myk, Assigned: myk)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.91 KB,
patch
|
bbaetz
:
review+
bbaetz
:
review+
|
Details | Diff | Splinter Review |
Flag.pm uses $vars sometimes when it needs $::vars, and it contains a reference
to &Param that should be &::Param (which actually causes a software error).
|
Assignee | |
Comment 1•23 years ago
|
||
|
||
Comment 2•23 years ago
|
||
Comment on attachment 101009 [details] [diff] [review]
patch v1: fixes problems
|use Bugzilla::Config| (and drop the &) and |use vars| instead
Attachment #101009 -
Flags: review-
|
|
||
Comment 3•23 years ago
|
||
*** Bug 171474 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Comment 4•23 years ago
|
||
Attachment #101009 -
Attachment is obsolete: true
|
|
||
Comment 5•23 years ago
|
||
Comment on attachment 101039 [details] [diff] [review]
patch v2: uses "Bugzilla::Config"
r=bbaetz x2
Long live Bugzilla::Template!
Attachment #101039 -
Flags: review+
|
|
Assignee | |
Comment 6•23 years ago
|
||
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v <-- Flag.pm
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•23 years ago
|
Blocks: rt-clean-up
|
||
Updated•23 years ago
|
Target Milestone: --- → Bugzilla 2.18
|
||
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•