1714283 - IDB: Fix building in non-unified builds

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P2)

Description

[Jan Varga [:janv]]

There are still some problems with building in non-unified mode:

In a debug build:

0:19.92 /Users/jvarga/Projects/Mozilla4/src/dom/indexedDB/ActorsChild.cpp:88:16: error: unused variable 'kFileCopyBufferSize' [-Werror,-Wunused-const-variable]

0:19.92 const uint32_t kFileCopyBufferSize = 32768;

0:19.92                ^

In an opt build:

0:46.71 /Users/jvarga/Projects/Mozilla4/src/dom/indexedDB/IndexedDatabaseInlines.h:182:8: error: no matching function for call to 'ToJSValue'

0:46.71   if (!ToJSValue(aCx, aBaseObject, &wrappedValue)) {

0:46.71        ^~~~~~~~~

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1714283 - IDB: Fix building in non-unified builds; r=#dom-storage

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:janv, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Jan Varga [:janv]]

Ok, I'll land it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72c168c505ea
IDB: Fix building in non-unified builds; r=dom-storage-reviewers,jstutte

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/72c168c505ea

Comment 6

[Jan Varga [:janv]]

Landed.