1714311 - IDBTransaction.h expected identifier CLEANUP, clash with macro in nss 3.66

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Andreas Baumann]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.7.1

Steps to reproduce:

compile normaly, have nss 3.66 installed (tried that on ArchLinux and Archlinux32).

Actual results:

/build/seamonkey/src/seamonkey-2.53.7.1/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/IDBTransaction.h
:62:5: error: expected identifier
CLEANUP,
^
/usr/include/nss/pk11hpke.h:12:5: note: expanded from macro 'CLEANUP'

Comment 1

[Andreas Baumann]

Downstream linked in https://bugs.archlinux.org/task/71113

Comment 2

[Andreas Baumann]

I see this has been solved in trunk with a rename:

    ReadOnly = 0,
    ReadWrite,
    ReadWriteFlush,
    Cleanup,
    VersionChange,

    // Only needed for IPC serialization helper, should never be used in code.
    Invalid
  };

Comment 3

[Robert-André Mauchin]

(In reply to Andreas Baumann from comment #2)

I see this has been solved in trunk with a rename:

Could you point out which commit solves the issue please?

Comment 4

[Frank-Rainer Grahl (:frg)]

SeaMonkey currently uses the latest ESR78 nss 3.53.1 library. We will only switch to later ones when ESR91 is released. There might be other changes needed.

For the cleanup you can try applying
https://www.wg9s.com/comm-253/patches/seamonkey-253-patches/mozilla-release/patches/1598164-3only-72a1.patch

It will be in 2.53.9. I didn't test if further work is needed.

Comment 5

[Dmitry Butskoy (:buc)]

Current Fedora's patch here, compiled successfully.

Comment 6

[Dmitry Butskoy (:buc)]

It should be in 2.53.8, otherwise any distro with nss >= 2.66 will apply it theirselves at downstream level anyway.

Comment 7

[Dmitry Butskoy (:buc)]

A simpler one from Archlinux: https://git.archlinux32.org/packages/tree/community/seamonkey/seamonkey-2.53.7.1-CLEANUP.patch

Comment 8

[Robert-André Mauchin]

(In reply to Dmitry Butskoy (:buc) from comment #5)

Current Fedora's patch here, compiled successfully.

Yeah that was me, I stole it from Arch, after checking with the original commit: https://hg.mozilla.org/mozilla-central/rev/82141e34c89fecaed2c0700bfc11d5b5401645a3

Comment 9

[Frank-Rainer Grahl (:frg)]

I will take a look if it applies clean. Wanted to do it today but was sidetracked.

Comment 10

[Frank-Rainer Grahl (:frg)]

Backport has landed in 2.53.8
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/213775d3307ee75bd45fc9c2a609a052fe880799

Keep in mind that using the latest NSS is still not officially supported.