Closed Bug 1714330 Opened 3 years ago Closed 3 years ago

geckodriver no longer waits for application shutdown nor force kills the browser process

Categories

(Testing :: geckodriver, defect, P3)

Firefox 91
defect

Tracking

(firefox-esr78 unaffected, firefox89 unaffected, firefox90 unaffected, firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- fixed

People

(Reporter: whimboo, Assigned: jgraham)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 obsolete file)

If the WebDriver:NewSession command from Marionette doesn't create a new session and returns a session not created error, geckodriver tries to shutdown the browser by deleting the session instead of force-killing it. This is actually a regression from bug 1705770.

I'll have a look given that I have all the required patches locally to reproduce it with the upcoming webSocketUrl capability.

Set release status flags based on info from the regressing bug 1705770

This fixes a regression as introduced by bug 1705770 that
causes geckodriver to no longer wait for the browser to
shutdown nor force killing it in case of shutdown issues
or with no session present.

Summary: geckodriver waits for application shutdown instead of force killing the process if "WebDriver:NewSession" fails → geckodriver no longer waits for application shutdown nor force kills the browser process
Attachment #9224955 - Attachment description: WIP: Bug 1714330 - [geckodriver] Ensure a clean browser shutdown. → Bug 1714330 - [geckodriver] Ensure a clean browser shutdown.
Blocks: 1443520
Attachment #9224955 - Attachment is obsolete: true

It will actually be fixed by the patch from James as recently attached on bug 1443520.

No longer blocks: 1443520
Depends on: 1443520
Assignee: hskupin → james

Fixed by bug 1443520.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: