1714382 - Include the Mac memory pressure state in crash reports

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement)

Description

[Haik Aftandilian [:haik]]

Include the Mac memory pressure state in crash reports so we can correlate crashes with the low memory signal from the OS and determine if the signal will be useful for tab unloading, memory pressure events, etc.

Comment 1

[Haik Aftandilian [:haik]]

Attachment: Bug 1714382 - Include the Mac memory pressure state in crash reports r?spohl,KrisWright

Comment 2

[Haik Aftandilian [:haik]]

Attachment: Data review request for new crash report annotations

Comment 3

[Chris H-C :chutten]

Comment on attachment 9231466 [details]
Data review request for new crash report annotations

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Haik Aftandilian is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f0fe70a0e34
Include the Mac memory pressure state in crash reports r=spohl,KrisWright

Comment 5

[Iulian Moraru]

Backed out for causing assertion failures on nsCycleCollector.cpp.

Push with failures

Failure log

Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32779cf61a9f
Include the Mac memory pressure state in crash reports r=spohl,KrisWright

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/32779cf61a9f

Comment 8

[Haik Aftandilian [:haik]]

Attachment: Bug 1714382 - Patch 2 - Correct description of MacMemoryPressureSysctl r?#mac-reviewers

Correct the description of the MacMemoryPressureSysctl crash annotation to indicate 1 is the value for normal memory pressure.

The integer values are from the XNU kernel event.h header file and observable with $ sysctl kern.memorystatus_vm_pressure_level.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8178d7cb017
Patch 2 - Correct description of MacMemoryPressureSysctl r=jrmuizel DONTBUILD

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f8178d7cb017