1714395 - Identify browser toolbox via descriptor or toolbox instead of top level target

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Today, we query TargetFront.isParentProcess in a few places:
https://searchfox.org/mozilla-central/search?q=.isParentProcess&path=devtools%2F&case=true&regexp=false

Theoriticaly, this is not ideal, in most case we use this attribute to know if we are in the browser toolbox. Ideally, we would query that from the DescriptorFront, which never changes. Or from the Toolbox, which knows if this is the BrowserToolbox.

I saw a couple of tests failing on such code. Because target was null.
It probably hide some other issue (code fired before targetCommand.startListening resolves, or code fired after destruction?), but at least we will no longer see this exception!

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1714395 - [devtools] Use descriptor front or toolbox to know if we are in a BrowserToolbox

That, instead of using the current top level target, which may change, be null, ...

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77ccabef4181
[devtools] Use descriptor front or toolbox to know if we are in a BrowserToolbox r=nchevobbe

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/77ccabef4181