Closed Bug 1714448 Opened 3 years ago Closed 3 years ago

Crackling sound in the beginning of the audio when seeking with currentTime

Categories

(Core :: Audio/Video: Playback, defect)

Firefox 89
Desktop
All
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: ksenia, Unassigned)

References

(Regression, )

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Attached file 68847.html (obsolete) —

The original problem is with duolingo.com stories where a lot of "stories" have this cracking sound in the beginning and it was reported in https://github.com/webcompat/web-bugs/issues/68847

It seems intermittent for certain audio files, but with the file in the reduced test case it's reproducible consistently.

From mozregression:

 4:06.82 INFO: No more integration revisions, bisection finished.
 4:06.82 INFO: Last good revision: b55828d6e11a0a4de1e0464c6239c64e429049fd
 4:06.82 INFO: First bad revision: 748e0d854d86610243b5a6e85e0c9e0f76f22f50
 4:06.82 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b55828d6e11a0a4de1e0464c6239c64e429049fd&tochange=748e0d854d86610243b5a6e85e0c9e0f76f22f50

FWIW, Duolingo is using Howler.js (https://github.com/goldfire/howler.js) and this is the reduced test case when using the library API https://codepen.io/ksy36/pen/GRWQXKM with two audio files

OS: Unspecified → macOS
Hardware: Unspecified → Desktop
Version: unspecified → Firefox 89
Attached file 68847.html
Attachment #9225077 - Attachment is obsolete: true

Comment on attachment 9225081 [details]
68847.html

(testcase without using howler.js)

Hi Paul, would you be able to take a look?

Flags: needinfo?(padenot)
OS: macOS → All
Component: Web Audio → Audio/Video: Playback

This is something that Duolingo put in place because in the past, Firefox didn't decode mp3 correctly. But I've fixed this somewhat recently in bug 1566389 as you found. Consequently, this is not something we should or even can fix.

Specifically, we used to not trim the very beginning of mp3s, which was incorrect, and here we see Duolingo skipping a very short portion of the file at the beginning, corresponding to this portion of the file. We now do trim this portion of the file (matching the behaviour of Chrome and Edge, which have been correct for a long time), so they should remove their workaround.

Skipping in the middle of a mp3, and landing on a zone where the audio is not silent frequently results in a burst of noise (like the example you gave us, which was very nice to understand what is going on), because it causes a discontinuity in the stream of audio sample, from a sample that is 0 (silent) to a sample that is non-zero (non-silent).

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(padenot) → needinfo?(kberezina)
Resolution: --- → INVALID

Thanks for the explanation, I've contacted Duolingo on github

Flags: needinfo?(kberezina)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: