1714517 - About preferences - bottom highlight on buttons inside modals is missing

Status: NEW

(Firefox :: Settings UI, defect, P3)

Description

[Catalin Sasca, Desktop QA [:csasca]]

Attachment: focus save and cancel.gif

Affected versions

• Firefox 90.0b3
• Firefox 91.0a1

Affected platforms

• Windows 8.1 & Windows 10
• Ubuntu 20.04

Steps to reproduce

1. Launch Firefox
2. Access about:preferences
3. Open the settings for example Autoplay
4. Press tab until the focus is over Save changes or Cancel

Expected result

• The focus on the buttons is fully visible

Actual result

• The bottom part of the focus is cut off

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the attachment
• Can't reproduce on macOS as the focus is not getting to the Save changes and Cancel button at all
• Other modals are affected as well

Comment 1

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,

Here's the regression range found:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=269819a25f93255894887689cac0df8e7dbf3cb5&tochange=b740f950e4971e9e17c16b0e19e569cd3b07ceb5

First good build 2021-04-01
First bad build 2021-05-01

Let me know if you need additional information

Best regards,
Clara

Comment 2

[Julien Cristau [:jcristau]]

The regression range from comment 1 includes bug 1700109, so I guess that's when it showed up.

Comment 3

[Pascal Chevrel:pascalc]

Could we have this bug triaged and prioritized? Thanks

Comment 4

[Jens Stutte [:jstutte]]

(In reply to Julien Cristau [:jcristau] from comment #2)

The regression range from comment 1 includes bug 1700109, so I guess that's when it showed up.

Let's ask there (I assume the component is not correct here then). Bernard, could you please take a look?

Comment 5

[Bernard Igiri]

I'm seeing this issue on MacOS as well. It appears that this can be resolved by increasing the minimum height on these modal dialogs, or perhaps removing some padding if doing so is within spec.

Comment 6

[:Gijs (he/him)]

I already fixed bits of this in bug 1705330. From a very quick look, the cause for the permissions (autoplay / microphone / etc.) is that the preferences sets the viewport size for the dialog to be too short. It sets this size based on a calculation of the size of the content of the dialog, so something about the required height of the contents changes between when that calculation is made, and the final rendering. I don't know what that thing is, but it should be reasonably straightforward to find out by logging the sizes of the things in the dialog (based on getBoundingClientRect().height) in the code at https://searchfox.org/mozilla-central/rev/a9db89754fb507254cb8422e5a00af7c10d98264/toolkit/modules/SubDialog.jsm#562-564, and compare it with the sizes later. I assume something is loaded asynchronously that changes size.

Anyway, this belongs in a frontend component.