1714559 - Extra space above bookmark this page popup

Status: NEW

(Firefox :: Bookmarks & History, defect, P5)

Description

[Andrew]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Visited a website and clicked on the star icon in the urlbar.

Actual results:

There is some extra padding above the 'bookmark this page' popup.
This is pretty unimportant in the grand scheme of things, but is still quite annoying.

I've noticed this in Firefox Stable 89 on Linux, and Firefox Nightly 91 on Linux and Windows.

Expected results:

I'd assume that the popup would be shown directly under the button, as are all other popups, and not floating a few pixels below it.

My guess is that #editBookmarkPanel should be added to panelUI.css on line 225. The extra margin is removed from the other popups, but not the bookmark this page popup: #downloadsPanel, #widget-overflow, #appMenu-popup, #customizationui-widget-panel, #identity-popup, #permission-popup, #protections-popup {margin-top: -4px;}. Note that the #editBookmarkPanel is missing from this list.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Mark Banner (:standard8)]

Please can you include an example screenshot of the issue?

Comment 3

[Andrew]

Attachment: bookmarkpopup.png

Comment 4

[Jeronimo Torti (Please send NI request to Brindusa Tot)]

Attachment: book.jpg

Comment 5

[Jeronimo Torti (Please send NI request to Brindusa Tot)]

Hi Andrew,
I was able to reproduce in Nightly 91.0a1 (2021-06-07) (64-bit) and Beta 90.0b4 (64-bit), but not in Release 89.0 Version (please, refer to screenshot 'book' in order to see how it looks after clicking star icon), where the design is different in pop-up that appears.

I set this as New, and updated flags accordingly.

Regards,
Jerónimo.

Comment 6

[Andrew]

Hello Jerónimo,

That's odd. I have been able tor reproduce this issue on Release 89.0 on Windows and Linux. My toolbar looks different from the one in your screenshot. Perhaps you don't have proton UI enabled?

This issue wasn't present in the old interface.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

There is some alignment problems with panels in Proton, we noticed some panels having gaps and some not also on Mac.
This is a polish/cleanup bug.