1714684 - remove "mock-1.0.0" vendored library

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task)

Description

[Mitchell Hentges [:mhentges] 🦀]

We have unittest.mock in Python 3, let's use that instead.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1714684: Remove usages of vendored "mock" library

Python 3 has access to unittest.mock in the standard library.

Depends on D117072

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1714684: Resolve `assert_has_calls()` usage error

The calls parameter is expected to be an iterable
container of calls, not a singular call.

This was working in mock-1.0.0 because calls
was (confusingly) allowed to be a single item
if any_order==False. This behaviour isn't
the same in th standard library.

Depends on D117073

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1714684: Remove unused "mock" vendored library

Depends on D117074

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1714684: Don't `assert` the result of `assert_called()`

In the vendored mock library, assert_called() returns the
MagicMock instance again - I'm not sure that it does the actual
assertion, so assert instance.is_called() may be a no-op.

Fortunately, in unittest.mock, assert_called() does the assertion
internally, and returns None. Since assert None causes a failure,
we need to tweak the invalid usage accordingly.

Depends on D117074

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7970286ea6a
Remove usages of vendored "mock" library r=perftest-reviewers,ahal,sparky
https://hg.mozilla.org/integration/autoland/rev/cf4fe27bad4e
Resolve `assert_has_calls()` usage error r=ahal
https://hg.mozilla.org/integration/autoland/rev/fd0fdbf27acd
Don't `assert` the result of `assert_called()` r=perftest-reviewers,AlexandruIonescu
https://hg.mozilla.org/integration/autoland/rev/0dad88dc18d6
Remove unused "mock" vendored library r=ahal

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f446b540fbe9
Fix linting. r=fix CLOSED TREE

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f7970286ea6a
https://hg.mozilla.org/mozilla-central/rev/cf4fe27bad4e
https://hg.mozilla.org/mozilla-central/rev/fd0fdbf27acd
https://hg.mozilla.org/mozilla-central/rev/0dad88dc18d6
https://hg.mozilla.org/mozilla-central/rev/f446b540fbe9