17147 - AddListeners mishandles case where Listenener already exists.

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Daniel Bratell]

A new listener is not added when adding a listener to a service already having a
listener in
nsMsgComposeAndSend::AddListener in /mozilla/mailnews/compose/src/nsMsgSend.cpp
and
nsMsgSendLater::AddListener in /mozilla/mailnews/compose/src/nsMsgSendLater.cpp

I think
    mListenerArrayCount = 1;
should be changed to
    mListenerArrayCount += 1;

and before
    return NS_OK;
should be
    mListenerArray[mListenerArrayCount-1] = aListener;

Comment 1

[rhp (gone)]

Good catch...already fixed in my tree and I will checkin this Monday.

- rhp

Comment 2

[rhp (gone)]

I fixed this...deals with the listeners properly.

- rhp

Comment 3

[ppandit]

Rich - can you point me to which revision numbers the changes were made in. I
can't find the exact changes you made regarding this bug.

Thanks,
Par

Comment 4

[rhp (gone)]

I'm really not sure on the CVS changes...had a problem finding them myself but
I sight checked the code and the changes are there.

- rhp

Comment 5

[ppandit]

based on what rhp says - VERIFIED