Closed Bug 1714748 Opened 5 years ago Closed 7 months ago

System theme description is inaccurate on Windows

Categories

(Firefox :: Messaging System, defect, P2)

Firefox 89
Unspecified
Windows
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: tcflorea, Unassigned)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Update to Windows 89 (on Windows 10)

Actual results:

The "Default theme" has been renamed as "System Theme" with the description "Follow the operating system setting for buttons, menus, and windows.".
This is actually not the case but various bug has been closed on this issue with resolution "WON"T FIX".

Expected results:

Since Firefox decided to drift away form following the system theme it should be fair to name the theme and provide an appropriate description for intended theme.

Component: Untriaged → Messaging System

NI Meridel to verify copy and help triage thanks

Flags: needinfo?(mwalkington)
Iteration: --- → 91.1 - May 31 - Jun 13
Priority: -- → P2
Severity: -- → S3

RE: "Since Firefox decided to drift away form following the system theme it should be fair to name the theme and provide an appropriate description for intended theme."

I don't think this is accurate, or it shouldn't be the case. What was formerly the "Default theme" is/should be the "System theme" and should indeed "follow the operating system setting for buttons, menus, and windows." Romain, are you aware of any changes to what was planned here?

Flags: needinfo?(mwalkington) → needinfo?(rtestard)

Not aware of any changes.
Tudor can you please clarify which limitations in particular you see with our dark/light system theme support?

Flags: needinfo?(rtestard) → needinfo?(tcflorea)

Please see the comment 1 "we're removed support" in the bug 1701266: and the resolution "Won't fix".
In Firefox prior to v89 there was a "default" theme: the active windows grey, the inactive light grey. The colours were similar with any on the application on my Windows 10 OS: Edge. Chrome, Notepad, etc).
Aside of the "default" theme Firefox used to have two other themes: the "dark" and the "light" themes. Those were either too dark or too light. Also there is no (visible) difference between active and inactive tab. One may assume that the theme/colours for my OS has been already tweaked as desired.

In Firefox v89, the default theme has been renamed "System theme" however the system them the somehow similar with the light theme: it became "too light.". Although "too light" is just a biased opinion, being a different colours is a fact. Firefox "system theme" does not follow the system colours any more.
I initially opened the bug 1714460 but then found the bug above and I think it will end up be a duplicate of the above.
With this in mind, the description of "System theme" in Firefox is simply deceiving if not wrong. I honestly don't know what would be a better name and a better description and I would refrain from suggesting anything to avoid having my comment tagged as advocacy.
Of course, one option would be to close this as well as "Won't fix".
I hope that clarify your questions and why I set the Messaging system component.

Flags: needinfo?(tcflorea)

On Linux, the background of the top/tab bar does reflect the system window coloring different from "Light" and "Dark" Firefox themes, so this seems to specifically affect Windows not following the accent color per wontfix bug 1701266.

The description on about:welcome and elsewhere do match the descriptions in about:addons for "System theme."

OS: Unspecified → Windows
See Also: → 1701266
Summary: System theme description → System theme description is inaccurate on Windows

Hi,
as per the previous comments, and since this issue is still being discussed, I'll mark it as NEW for visibility.
Thanks.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Iteration: 91.1 - May 31 - Jun 13 → 91.2 - Jun 14 - Jun 27
Iteration: 91.2 - Jun 14 - Jun 27 → ---
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: