1714872 - Several "unknown option -msse4.1" build warnings when compiling SeaMonkey 2.53 and 2.57 with MSVC

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, task)

Description

[Frank-Rainer Grahl (:frg)]

MSVC is no longer supported in central but we still allow for it.

media\libwebp\src\dsp\moz.build sets -msse4.1 unconditionally which is wrong for MSVC. It uses -arch: but there is no option for SSE4.1. Files compile fine even without because the instructions are enabled in the affected cpp file. So just do not set this for Windows when using this compiler only.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1714872-msvc-nosse41-2539.patch

For our private 2.53 and 2.57 branches only.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: no impact. We ship webp since a few releases already.
Testing completed (on m-c, etc.): 2.53.9b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9225469 [details] [diff] [review]
1714872-msvc-nosse41-2539.patch

[Triage Comment]
As far as I can tell this good, if it doesn't break anything on your / WG9s' builds r/a=me

Comment 3

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/64ffe13a447babf81a97a3ef21735c2c0b027b5c
Do not set -msse4.1 when compiling with MSVC. r=IanN a=IanN