Closed
Bug 1714885
Opened 4 years ago
Closed 4 years ago
Cleanup css added for dark mode support in about debugging
Categories
(DevTools :: about:debugging, task, P3)
DevTools
about:debugging
Tracking
(firefox91 fixed)
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
In Bug 1712511, some CSS was added for dark mode support in about:debugging. It doesn't follow the usual guidelines we used in this UI. In particular, colors have been hardcoded without defining variables.
For instance the following color https://searchfox.org/mozilla-central/rev/c1ec9ecbbc7eac698923ffd18c8594aa3e2e9da0/devtools/client/aboutdebugging/src/base.css#448 should rather be a variable.
|
Assignee | |
Comment 1•4 years ago
|
||
All the customizations for dark theme now use variables defined in base.css
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6e284ddc59b
[devtools] Consolidate dark theme customizations for aboutdebugging in base.css r=daisuke
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•