1714910 - "Reopen closed tab" does not preserve request method

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Will Barkoff]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

1. Navigate to a page via a POST request.
2. Close the tab
3. Re-open the tab with Command+Shift+T/Ctrl+Shift+T or by going to to History > Recently Closed Tabs
4. Refresh the page.

Actual results:

A GET request is performed

Expected results:

The user should be prompted first for another POST request (like what happens when you don't close and re-open the tab), then a POST request should be performed.

Comment 1

[Marcela (Please NI request to Brindusa Tot)]

Hi Will !
In order to reproduce this issue, could you please add a test case to do it or the URL that you are using?
Also, if it is possible, could you add a screen recording showing where the problem is?.
Thanks!

Comment 2

[Will Barkoff]

Attachment: bug-demo-2.mov

Hi Marcela!

I spun up a quick demo at https://firefox-bug-1714910.willbarkoff.dev/ (source: https://github.com/willbarkoff/firefox-bug-1714910). I've also attached a screen recording to demonstrate what I'm discussing.

Please let me know if you need anything else!
Will

Comment 3

[Marcela (Please NI request to Brindusa Tot)]

Thank you for the information.
I was able to reproduce this issue on latest Nightly 91.0a1 (2021-06-09)(64-bit), Beta 90.0b4, and Release 89.0 on macOS 10.15 and Windows 10.
I'll change flags accordingly.
Severity suggested S2.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

This bug seems to have always been around. I tested with Firefox 51 and it was still there.
It doesn't seem to happen in Chrome, Safari or Edge.

It seems to be caused by the fact that we don't hold on to the actual channel and/or upload stream when we close the tab, and so probably no info whether the closed tab was a post or a get.