1714918 - Sort out accessors of editor concrete classes

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

• nsIEditor::As* is sometimes used instead of nsIEditor::Is*()
• nsIEditor::As* should just cast
• Instead, nsIEditor::GetAs*() should check the concrete class like internal DOM API

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1714918 - Sort out editor class accessors of `nsIEditor` r=m_kato!

For consistency with the similar internal DOM API, As*() should just cast
the type without checking editor type. Instead, GetAs*() should do it.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Posted to dev-platform: https://groups.google.com/a/mozilla.org/g/dev-platform/c/hVXQK457tME

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/150c70a6850a
Sort out editor class accessors of `nsIEditor` r=m_kato

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/150c70a6850a