1715000 - The about:sessionrestore page has an unnecessary scrollbar while the list of pages to restore does not have one

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Daniel Bodea [:danibodea]]

Attachment: sessionrestore page scrollbar.webm

Note

• When the user has more than 5 opened tabs/windows and then he intentionally crashes the browser or somehow reaches the about:sessionrestore page, he will notice that when scrolling the list of tabs/windows to restore, the whole page is scrolling instead of just the list.

Affected versions

• Nightly v91.0a1
• Beta v89.0b4
• Release v89.0

Affected platforms

• all

Steps to reproduce

1. Launch browser.
2. Open a few tabs. (10 tabs will certainly be enough)
3. Load "about:crashparent" in the address bar to crash the browser.
4. Restart the browser from the "Browser has crashed" window.
5. On the Session Restore page, click the "View Previous Tabs" drop-down/button.
6. Scroll the list of windows/tabs that you can choose to restore.

Expected result

• The list is scrolling up/down correctly, not the whole page as well.

Actual result

• I see 3 important issues here:
  ** The Session Restore page is too long; A scrollbar is not necessary on screens with resolutions as small as 1440x900.
  ** The list of windows/tabs to restore is missing a scrollbar.
  ** When hovering (over the list of windows/tabs to restore) and scrolling it, both the list and the whole page scrolls at the same time.

Regression range

• A part of these issues appears to be a regression because the ESR v78.11.0esr does not show a scrollbar on the Session Restore page, so the other 2 issues aren't so relevant here.
• This is most probably an implementation issue, not an unintentional regression. NI me if a regressor investigation is necessary.

Comment 1

[Alice0775 White]

#1 Regression window for ** The list of windows/tabs to restore is missing a scrollbar:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=47e7e2dac7c99f9c5fa555bdb579ec18f1674c72&tochange=3296484c0237d1649160e337777979afff76f80b

Suspect: 2b59993a9659cd432afe453dcb4d3cc75aca7ba5 Paolo Amadini — Bug 1516258 - Part 2 - Remove XULScrollElement. r=NeilDeakin

#2 Regression window for ** The Session Restore page is too long and ** When mouse wheel scrolling the list, both the list and the whole page scrolls at the same time.:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8aa1b80a8c6b66cccc2e37080fbf6197eee8d801&tochange=1716229005d8b97f305bd663b8bc8d3fec4a4f3a

Suspect: 1716229005d8b97f305bd663b8bc8d3fec4a4f3a Bernard Igiri — Bug 1700109 - Enable main Proton pref by default in Nightly r=dao,jaws