Closed Bug 1715144 Opened 3 years ago Closed 2 years ago

Stop adding ipc/glue to LOCAL_INCLUDES in chromium-config.mozbuild

Categories

(Core :: IPC, task)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- wontfix
firefox97 --- fixed

People

(Reporter: nika, Assigned: nika)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Headers in ipc/glue are already exported using the normal EXPORTS mechanism under paths like mozilla/ipc/**.h, so consumers shouldn't need to use LOCAL_INCLUDES to use them.

Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e8903c33b67
Part 1: Stop adding /ipc/glue to LOCAL_INCLUDES when including chromium-config.mozbuild, r=ipc-reviewers,necko-reviewers,mccr8,valentin
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---

The leave-open keyword is there and there is no activity for 6 months.
:nika, maybe it's time to close this bug?

Flags: needinfo?(nika)
Attachment #9225775 - Attachment description: Bug 1715144 - Part 2: Stop adding /ipc/glue to LOCAL_INCLUDES in gn-generated files, → Bug 1715144 - Part 2: Stop adding /ipc/glue to LOCAL_INCLUDES in gn-generated files, r=nalexander,jib
Flags: needinfo?(nika)
Keywords: leave-open
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6eaab8644f7
Part 2: Stop adding /ipc/glue to LOCAL_INCLUDES in gn-generated files, r=firefox-build-system-reviewers,nalexander,jib
Status: REOPENED → RESOLVED
Closed: 3 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: