1715311 - Crash in [@ (anonymous namespace)::ParticularProcessPriorityManager::ActivityChanged]

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

Crash report: https://crash-stats.mozilla.org/report/index/4d806bcc-fd45-4867-b362-c20b40210608

Reason: SIGSEGV /SEGV_MAPERR

Top 10 frames of crashing thread:

0 libxul.so  dom/ipc/ProcessPriorityManager.cpp:725
1 libxul.so std::__ndk1::__function::__func< /builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include/functional:1714
2 libxul.so mozilla::dom::BrowsingContext::PreOrderWalkVoid docshell/base/BrowsingContext.cpp:1004
3 libxul.so mozilla::ProcessPriorityManager::ActivityChanged dom/ipc/ProcessPriorityManager.cpp:878
4 libxul.so mozilla::dom::BrowserHost::SetRenderLayers dom/ipc/BrowserHost.cpp:120
5 libxul.so {virtual override thunk} 
6 libxul.so NS_InvokeByIndex xpcom/reflect/xptcall/md/unix/xptcinvoke_arm.cpp:167
7 libxul.so XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1143
8 libxul.so XPC_WN_GetterSetter js/xpconnect/src/XPCWrappedNativeJSOps.cpp:953
9 libxul.so js::CallSetter js/src/vm/Interpreter.cpp:729

60/40 split on ARMv7 vs ARM64 which is unusual.

Comment 1

[Andrew McCreight [:mccr8]]

Maybe we should null check canonical->GetBrowserParent() in ProcessPriorityManagerImpl::ActivityChanged.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1715311 - Null check GetBrowserParent() in ProcessPriorityManagerImpl::ActivityChanged.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2050f2cde135
Null check GetBrowserParent() in ProcessPriorityManagerImpl::ActivityChanged. r=kmag

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2050f2cde135

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mccr8, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 9226394 [details]
Bug 1715311 - Null check GetBrowserParent() in ProcessPriorityManagerImpl::ActivityChanged.

Beta/Release Uplift Approval Request

• User impact if declined: Crashes. These are only showing on Fenix for some reason, but in theory they could affect Windows, too.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is just a null check.
• String changes made/needed: none

Comment 7

[Andrew McCreight [:mccr8]]

This crash has not recurred on Nightly since my patch landed, though the crash volume is low enough that it is hard to tell for sure that it has been fixed.

Comment 8

[Andrew McCreight [:mccr8]]

Probably a regression from bug 1618547.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9226394 [details]
Bug 1715311 - Null check GetBrowserParent() in ProcessPriorityManagerImpl::ActivityChanged.

approved for 90.0b8

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bcbb28b22dc2

Comment 11

[Andrew McCreight [:mccr8]]

Looks like it has not recurred on either Nightly or beta since the patch landed.