1715504 - Banner variations for Private Browsing mode experiment

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

Design https://www.figma.com/file/nE9oYYDHGT9yx3lyJgvQsE/Continuous-Onboarding---VPN-(Copy)?node-id=286%3A2500

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1715504 - Banner variations for Private Browsing mode experiment

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4ab27bcac2e
Banner variations for Private Browsing mode experiment r=desktop-theme-reviewers,k88hudson,harry

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser_all_files_referenced

Backout link: https://hg.mozilla.org/integration/autoland/rev/14ce2eae405e528376674589a42a5f8b920ac4c3

Push with failures

Failure log

Comment 4

[Andrei Oprea [:andreio]]

Unreferenced files are activated by experiment recipe delivered remotely via Remote Settings. Added to the exception list.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24e274413c45
Banner variations for Private Browsing mode experiment r=desktop-theme-reviewers,k88hudson,harry

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/24e274413c45

Comment 7

[Andrei Oprea [:andreio]]

Comment on attachment 9226086 [details]
Bug 1715504 - Banner variations for Private Browsing mode experiment

Beta/Release Uplift Approval Request

• User impact if declined: Can't run planned experiment in Firefox 90
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): UI only changes triggered by experiment enrollment/low risk to rollback
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9226086 [details]
Bug 1715504 - Banner variations for Private Browsing mode experiment

approved for 90.0b11

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9226086 [details]
Bug 1715504 - Banner variations for Private Browsing mode experiment

Actually, no. This touches code added in bug 1714449 which is not in beta.

Comment 10

[Julien Cristau [:jcristau]]

Sorry, got my bugs mixed up. This one also doesn't graft cleanly to beta though, with conflicts in tests; please provide a rebased patch.

Comment 11

[Andrei Oprea [:andreio]]

Created a new patch rebased on beta as a separate phab patch let me know if this works or I should override the existing/accepted patch.

Comment 12

[Andrei Oprea [:andreio]]

Attachment: Bug 1715504 - Banner variations for Private Browsing mode experiment

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9228427 [details]
Bug 1715504 - Banner variations for Private Browsing mode experiment

That works, thanks. Should make it to the last beta build (90.0b12) tomorrow.

Comment 14

[Mike Kaply [:mkaply]]

Who can I talk to about not showing this if enterprise policies are enabled?

Comment 15

[Andrei Oprea [:andreio]]

Regarding comment 14 we're adding additional targeting to check if policies are enabled in bug 1717871.

Comment 16

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ff42d7828993

Comment 17

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps from here and I can confirm that all the three branches respect the design specifications

Verified using the latest Firefox Beta (90.0b12 Build ID - 20210624190035) and the latest Firefox Nightly (91.0a1 Build ID - 20210624093849) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64.