1715547 - Remove the Inner interface from ServiceWorker, ServiceWorkerContainer, and ServiceWorkerRegistration

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task)

Description

[Yaron Tausky [:ytausky]]

With child intercept code gone, we could remove a layer of abstraction that was introduced to accommodate two different implementations.

Comment 1

[Yaron Tausky [:ytausky]]

Attachment: Bug 1715547 - Remove ServiceWorkerRegistration::Inner r=asuth

Comment 2

[Eden Chuang[:edenchuang]]

Attachment: Bug 1715547 - Remove ServiceWorkerContainer::Inner r=asuth

Depends on D117344

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Bug 1715547 - Remove ServiceWorker::Inner r=asuth

Depends on D138999

Comment 4

[Eden Chuang[:edenchuang]]

Attachment: Bug 1715547 - Remove ServiceWorkerPrivate::Inner r=asuth

Depends on D139000

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85b20f601145
Remove ServiceWorkerRegistration::Inner r=asuth
https://hg.mozilla.org/integration/autoland/rev/8af1f4a4be08
Remove ServiceWorkerContainer::Inner r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/c8985e7c6a71
Remove ServiceWorker::Inner r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/c2114b608577
Remove ServiceWorkerPrivate::Inner r=asuth,dom-worker-reviewers

Comment 6

[Sandor Molnar]

Backed out 4 changesets (bug 1715547) for causing leakcheck failures in ServiceWorkerPrivate.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e6ea00f944000c239404e8796c93b43691b5c055

Failure log

Push with failure

Comment 7

[Eden Chuang[:edenchuang]]

Attachment: Bug 1715547 - Blocking SerivceWorker interception for no_cors cross-origin range request. r=#dom-worker-reviewers

Comment 8

[Phabricator Automation]

Comment on attachment 9276872 [details]
Bug 1715547 - Blocking SerivceWorker interception for no_cors cross-origin range request. r=#dom-worker-reviewers

Revision D146552 was moved to bug 1762078. Setting attachment 9276872 [details] to obsolete.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93250012e5ac
Remove ServiceWorkerRegistration::Inner r=asuth
https://hg.mozilla.org/integration/autoland/rev/6d0a9db1638c
Remove ServiceWorkerContainer::Inner r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/b02cb05ea06c
Remove ServiceWorker::Inner r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/64e584ac229b
Remove ServiceWorkerPrivate::Inner r=asuth,dom-worker-reviewers

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/93250012e5ac
https://hg.mozilla.org/mozilla-central/rev/6d0a9db1638c
https://hg.mozilla.org/mozilla-central/rev/b02cb05ea06c
https://hg.mozilla.org/mozilla-central/rev/64e584ac229b

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for causing frequent crashes:
https://hg.mozilla.org/integration/autoland/rev/58596af91c9397ae9e5e7edab9eb4f2bb4179f2f

1. bug 1790762

[@ nsCOMPtr<T>::get | nsCOMPtr<T>::operator nsIPrincipal* | mozilla::dom::ServiceWorkerInfo::Principal]
e.g. bp-22e85bee-3fcb-43e7-b473-a489e0220914
27 crashes from 21 installations.

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/a3b25b7bf192
Backed out 4 changesets for frequent autoland crashes. CLOSED TREE

Comment 13

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 desktop browser crashes on nightly

:edenchuang, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Comment 14

[Eden Chuang[:edenchuang]]

The crashes are caused by the backed-out patch. So we don't consider increasing the severity of it.

Comment 15

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit auto_nag documentation.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/825277ae13f4
Remove ServiceWorkerRegistration::Inner r=asuth
https://hg.mozilla.org/integration/autoland/rev/57af4021e491
Remove ServiceWorkerContainer::Inner r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/7b1656140268
Remove ServiceWorker::Inner r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/94fbc4e4411b
Remove ServiceWorkerPrivate::Inner r=asuth,dom-worker-reviewers

Comment 17

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/825277ae13f4
https://hg.mozilla.org/mozilla-central/rev/57af4021e491
https://hg.mozilla.org/mozilla-central/rev/7b1656140268
https://hg.mozilla.org/mozilla-central/rev/94fbc4e4411b