Open Bug 1715547 Opened 11 months ago Updated 6 hours ago

Remove the Inner interface from ServiceWorker, ServiceWorkerContainer, and ServiceWorkerRegistration

Categories

(Core :: DOM: Service Workers, task)

Product:
Core
Component:
DOM: Service Workers
Type:
task

Tracking

()

Status:
ASSIGNED

People

(Reporter: ytausky, Assigned: edenchuang)

References

Details

Attachments

(4 files, 1 obsolete file)

Bug 1715547 - Remove ServiceWorkerRegistration::Inner r=asuth
48 bytes, text/x-phabricator-request
Details | Review
Bug 1715547 - Remove ServiceWorkerContainer::Inner r=asuth
48 bytes, text/x-phabricator-request
Details | Review
Bug 1715547 - Remove ServiceWorker::Inner r=asuth
48 bytes, text/x-phabricator-request
Details | Review
Bug 1715547 - Remove ServiceWorkerPrivate::Inner r=asuth
48 bytes, text/x-phabricator-request
Details | Review

With child intercept code gone, we could remove a layer of abstraction that was introduced to accommodate two different implementations.

Assignee: nobody → ytausky
Status: NEW → ASSIGNED
Assignee: ytausky → jstutte
Assignee: jstutte → echuang

Depends on D138999

Depends on D139000

Pushed by echuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85b20f601145
Remove ServiceWorkerRegistration::Inner r=asuth
https://hg.mozilla.org/integration/autoland/rev/8af1f4a4be08
Remove ServiceWorkerContainer::Inner r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/c8985e7c6a71
Remove ServiceWorker::Inner r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/c2114b608577
Remove ServiceWorkerPrivate::Inner r=asuth,dom-worker-reviewers

Backed out 4 changesets (bug 1715547) for causing leakcheck failures in ServiceWorkerPrivate.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e6ea00f944000c239404e8796c93b43691b5c055

Failure log

Push with failure

Flags: needinfo?(echuang)

Comment on attachment 9276872 [details]
Bug 1715547 - Blocking SerivceWorker interception for no_cors cross-origin range request. r=#dom-worker-reviewers

Revision D146552 was moved to bug 1762078. Setting attachment 9276872 [details] to obsolete.

Attachment #9276872 - Attachment is obsolete: true
Flags: needinfo?(echuang)
You need to log in before you can comment on or make changes to this bug.