Select prompts should be dismissed when user clicks other fields
Categories
(GeckoView :: General, enhancement, P1)
Tracking
(firefox-esr91 wontfix, firefox100 wontfix, firefox101 wontfix, firefox102 wontfix, firefox103 fixed, firefox104 wontfix, firefox105 wontfix, firefox106 wontfix, firefox110 fixed)
People
(Reporter: petru, Assigned: m_kato)
References
Details
(Whiteboard: [geckoview:m105] [geckoview:m106] [geckoview:m107] [geckoview:m108] [geckoview:m109] [geckoview:m110])
Attachments
(4 files, 1 obsolete file)
Needed for https://github.com/mozilla-mobile/fenix/issues/19707
We currently have the onLoginSelect
and onCreditCardSelect
prompts which will be triggered whenever the user clicks on a field that can be autocompleted with that type of data.
But these prompts will stay on the screen (at the bottom) until they are consumed by the user picking an item to be autocompleted.
I propose a similar API, maybe something like onCancelLoginSelect
and onCancelCreditCardSelect
for when the user clicks in another field / another part of the page which cannot be autocompleted with the data from that prompt.
And then, when the user clicks again in a credit card / login field for the prompt to be re-requested.
I think this would lead to a similar UX as on desktop.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 1•3 years ago
|
||
FWIW I don't think we need a new API for this, onPromptDismiss
is already present in PromptInstanceDelegate
which all promps have: https://searchfox.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java#3744
we just need to call dismiss
on the prompt when we navigate away on the JS side.
Comment 3•2 years ago
|
||
Assigning to m_kato who was assigned to the duplicate.
Assignee | ||
Comment 4•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Comment 5•2 years ago
|
||
Bumping priority to P1 since Makoto is working on this bug.
Updated•2 years ago
|
Assignee | ||
Comment 6•2 years ago
|
||
Depends on D146913
Assignee | ||
Comment 7•2 years ago
|
||
We need to handle FormAutoComplete:ClosePopup
to dismiss autocomplete pop up.
When we add some tests for autocomplete, it may cause test failure due to test
order. Pop up is opened before using fetched data. So I add a workaround to
remove previous credit card and address information for some tests.
Depends on D147054
Comment 8•2 years ago
|
||
Carrying forward to 103. Agi says this fix will be too complex to uplift to Beta 102.
Comment 10•2 years ago
|
||
bugherder |
Assignee | ||
Comment 11•2 years ago
|
||
This bug has leave-open keyword
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
bugherder |
Comment 14•2 years ago
|
||
Makoto, this bug has the leave-open
keyword. You landed a prompt fix last month in 103 (comment 12) and all the dependencies are resolved. Is any work remaining? Or can we remove the leave-open
keyword and resolved this bug as FIXED?
Assignee | ||
Comment 15•2 years ago
|
||
Makoto, this bug has the leave-open keyword. You landed a prompt fix last month in 103 (comment 12) and all the dependencies are resolved. Is any work remaining? Or can we remove the leave-open keyword and resolved this bug as FIXED?
I have to update a fix for D147055. Now I am working it now.
Comment 16•2 years ago
|
||
(In reply to Makoto Kato [:m_kato] from comment #15)
I have to update a fix for D147055. Now I am working it now.
In that case, I will add this bug to our 105 sprint bugs.
Updated•2 years ago
|
Comment 17•2 years ago
|
||
Rolling this bug over to 106
Makoto, you have some code changes planned based on review feedback. Will you have time to make the changes and land them in the Nightly 106 cycle?
Assignee | ||
Comment 18•2 years ago
|
||
Assignee | ||
Comment 19•2 years ago
|
||
I would like to clean up GeckoViewAutocomplete
to share toolkit's code and
add more delegations.
Updated•2 years ago
|
Assignee | ||
Comment 20•2 years ago
|
||
Depends on D147055
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 21•2 years ago
|
||
(In reply to Chris Peterson [:cpeterson] from comment #17)
Rolling this bug over to 106
Makoto, you have some code changes planned based on review feedback. Will you have time to make the changes and land them in the Nightly 106 cycle?
Sorry for delay. It may be too late in 106...
Comment 22•2 years ago
|
||
Nightly 106 soft freeze starts tomorrow. We should probably wait until next week and land this fix in Nightly 107. That will give us more Nightly test time.
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 23•2 years ago
|
||
Comment 24•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/965040ea8caf
https://hg.mozilla.org/mozilla-central/rev/21babdb0982a
Description
•