1715572 - Select prompts should be dismissed when user clicks other fields

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

Needed for https://github.com/mozilla-mobile/fenix/issues/19707

We currently have the onLoginSelect and onCreditCardSelect prompts which will be triggered whenever the user clicks on a field that can be autocompleted with that type of data.

But these prompts will stay on the screen (at the bottom) until they are consumed by the user picking an item to be autocompleted.

I propose a similar API, maybe something like onCancelLoginSelect and onCancelCreditCardSelect for when the user clicks in another field / another part of the page which cannot be autocompleted with the data from that prompt.
And then, when the user clicks again in a credit card / login field for the prompt to be re-requested.

I think this would lead to a similar UX as on desktop.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

FWIW I don't think we need a new API for this, onPromptDismiss is already present in PromptInstanceDelegate which all promps have: https://searchfox.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java#3744

we just need to call dismiss on the prompt when we navigate away on the JS side.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Assigning to m_kato who was assigned to the duplicate.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1715572 - Choice prompt should be dismissed when focus is lost by content script. r=#geckoview-reviewers

Comment 5

[Chris Peterson [:cpeterson]]

Bumping priority to P1 since Makoto is working on this bug.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1715572 - DateTime prompt should be dismissed when focus is lost by content script. r=#geckoview-reviewers

Depends on D146913

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1715572 - Part 4. Allow more autocomplete delegations for GeckoView. r=#geckoview-reviewers,sgalich!

We need to handle FormAutoComplete:ClosePopup to dismiss autocomplete pop up.

When we add some tests for autocomplete, it may cause test failure due to test
order. Pop up is opened before using fetched data. So I add a workaround to
remove previous credit card and address information for some tests.

Depends on D147054

Comment 8

[Chris Peterson [:cpeterson]]

Carrying forward to 103. Agi says this fix will be too complex to uplift to Beta 102.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f2d85a32350
Choice prompt should be dismissed when focus is lost by content script. r=geckoview-reviewers,agi

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f2d85a32350

Comment 11

[Makoto Kato [:m_kato]]

This bug has leave-open keyword

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a1a61daa78f
DateTime prompt should be dismissed when focus is lost by content script. r=geckoview-reviewers,agi

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6a1a61daa78f

Comment 14

[Chris Peterson [:cpeterson]]

Makoto, this bug has the leave-open keyword. You landed a prompt fix last month in 103 (comment 12) and all the dependencies are resolved. Is any work remaining? Or can we remove the leave-open keyword and resolved this bug as FIXED?

Comment 15

[Makoto Kato [:m_kato]]

Makoto, this bug has the leave-open keyword. You landed a prompt fix last month in 103 (comment 12) and all the dependencies are resolved. Is any work remaining? Or can we remove the leave-open keyword and resolved this bug as FIXED?

I have to update a fix for D147055. Now I am working it now.

Comment 16

[Chris Peterson [:cpeterson]]

(In reply to Makoto Kato [:m_kato] from comment #15)

I have to update a fix for D147055. Now I am working it now.

In that case, I will add this bug to our 105 sprint bugs.

Comment 17

[Chris Peterson [:cpeterson]]

Rolling this bug over to 106

Makoto, you have some code changes planned based on review feedback. Will you have time to make the changes and land them in the Nightly 106 cycle?

Comment 18

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=9fec9d120102e4f553270d0ff62d3fa06dbb4661

Comment 19

[Makoto Kato [:m_kato]]

Attachment: Bug 1715572 - Part 3. Delegate dismiss popup of AutocompleteParent to GeckoView. r=#geckoview-reviewers

I would like to clean up GeckoViewAutocomplete to share toolkit's code and
add more delegations.

Comment 20

[Makoto Kato [:m_kato]]

Attachment: Bug 1715572 - Part 4. Add geckoview-junit test. r=#geckoview-reviewers

Depends on D147055

Comment 21

[Makoto Kato [:m_kato]]

(In reply to Chris Peterson [:cpeterson] from comment #17)

Rolling this bug over to 106

Makoto, you have some code changes planned based on review feedback. Will you have time to make the changes and land them in the Nightly 106 cycle?

Sorry for delay. It may be too late in 106...

Comment 22

[Chris Peterson [:cpeterson]]

Nightly 106 soft freeze starts tomorrow. We should probably wait until next week and land this fix in Nightly 107. That will give us more Nightly test time.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/965040ea8caf
Part 3. Delegate dismiss popup of AutocompleteParent to GeckoView. r=geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/21babdb0982a
Part 4. Add geckoview-junit test. r=geckoview-reviewers,owlish

Comment 24

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/965040ea8caf
https://hg.mozilla.org/mozilla-central/rev/21babdb0982a