Closed Bug 1715576 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29312 - [WebRTC] Preparation CL for making Plan B throw an exception.

Categories

(Core :: WebRTC, task, P4)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29312 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29312
Details from upstream follow.

b'Henrik Bostr\xc3\xb6m <hbos@chromium.org>' wrote:

[WebRTC] Preparation CL for making Plan B throw an exception.

This CL adds the code that makes constructing an RTCPeerConnection with
{sdpSemantics:"plan-b"} throw an exception, however it also adds a kill
switch for this code path that is enabled by default (meaning we will
not throw an exception).

The kill switch will be made DISABLED_BY_DEFAULT in a follow-up CL so
that in case we have to revert "making Plan B throw" we don't have to
revert evertything this CL is adding, including a web platform test and
a use counter that is likely to cause merge conflicts if reverted.

Bug: chromium:857004
Change-Id: I8452b6d883ec71ba77cc59275b038ae2cac41c73
Reviewed-on: https://chromium-review.googlesource.com/2949808
WPT-Export-Revision: 9ec17ca4f731e3ed26ca6c2b2f54d11c1979e464

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36ee9627f4b6
[wpt PR 29312] - [WebRTC] Preparation CL for making Plan B throw an exception., a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.