1715690 - Bucket WebGL RENDERER strings

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement)

Description

[Kelsey Gilbert [:jgilbert]]

While RENDERER is useful, it also exposes more info than necessary. E.g. there's no strong reason for websites to see that a user has a RTX 3070 instead of an RTX 3060. It is, however, useful to distinguish e.g. an 8800 GTX from a 1080, and websites can probably already distinguish them somewhat based on extensions, limits, and possibly rendering differences.

My goal here is to roughly bucket things, but neither too coarse nor too fine.

Comment 1

[Kelsey Gilbert [:jgilbert]]

After we have something safer like this, we might want to consider replacing webgl's RENDERER with this bucketized UNMASKED_RENDERER, disable the extension by default, and let UNMASKED_RENDERER return the real RENDERER again.

I'm hesitant though, since I expect many websites don't even bother with RENDERER, and just jump to UNMASKED_RENDERER-or-bust. For example, Safari does always return the same "Apple GPU" for all GPUs, this is still its UNMASKED_RENDERER. Its RENDERER is still "WebKit WebGL".

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1715690 - Generalize WebGL RENDERER into large buckets.

• Minor reduction in unused flexibility of limits.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1715690 - Generalize WebGL RENDERER into large buckets.

• Minor reduction in unused flexibility of limits.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1715690 - Generalize WebGL RENDERER into large buckets.

• Minor reduction in unused flexibility of limits.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67b696ec70a9
Generalize WebGL RENDERER into large buckets. r=lsalzman

Comment 6

[Iulian Moraru]

Backed out for causing build bustages on SanitizeRenderer.cpp.

Push with failures

Failure log

Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45887183c584
Generalize WebGL RENDERER into large buckets. r=lsalzman

Comment 8

[Atila Butkovits]

Backed out for causing failures at SanitizeRenderer.

Backout link: https://hg.mozilla.org/integration/autoland/rev/74c6c2a2748abb6f65f76e43f7166e3d5ba1a836

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=U_1m5rMcSuureR2SDgMOHw.0&revision=45887183c58464ee1bd9a747383140951c19aaae&searchStr=android%2C7.0%2Cx86-64%2Copt%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-gtest-e10s%2Cgtest

Failure log: https://treeherder.mozilla.org/logviewer?job_id=342567675&repo=autoland&lineNumber=6121

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40a0274fbc99
Generalize WebGL RENDERER into large buckets. r=lsalzman

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/40a0274fbc99