1715722 - [Proton] Carets from Bookmarks Panel are not aligned vertically inside button and adjacent ones

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: Untitled.png

Affected versions

• 91.0a1 (2021-06-09)

Affected platforms

• verified only on Windows 10;

Preconditions

• The following prefs are set to true in about:config:
  - browser.proton.enabled
  - browser.proton.doorhangers.enabled

Steps to reproduce

1. Go to any site.
2. Bookmark the page.
3. Click to expand the location or tags section;
4. Observe the arrows on the panels;

Expected result

• The arrows are aligned

Actual result

• The arrow of the button is offset by 1-2 pixels;

Regression range

• might be related to work on 1702486 or 1705494;

Additional notes

• attached image to illustrate the issue(zoom-ing in requiered);
• same when swapping the display order, the caret is still not centered inside the button.

Comment 1

[Oana Botisan, Desktop QA]

I managed to reproduce this issue using Ubuntu 18.04 x64 as well.
last good: 2021-04-01
first bad: 2021-04-02
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=89f7f47b16b30c37586f0477dab670f531df6099&tochange=9a88f4665c16d6acf5008c1990f9f81e2f95fee5
Potential regressor: bug 1702486

Comment 2

[Itiel]

Attachment: Bug 1715722 - Remove obsolete .button-box padding rule on Windows r?#desktop-theme-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11fb0d1f0a31
Remove obsolete .button-box padding rule on Windows r=desktop-theme-reviewers,harry,dao

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/11fb0d1f0a31

Comment 5

[Gabi Cheta [:Gabi] Desktop QA]

Issue is verified as fixed on Windows 10x64.
Issues still occurs on Ubuntu 20.4, should we mark this one with Verified and log a new issue for Ubuntu or should we reopen this one ?

Comment 6

[Itiel]

Please file a new bug and needinfo me there. Also please post a screenshot in that new bug.

Comment 7

[Max Vlasov]

The reporter of the bug https://bugzilla.mozilla.org/show_bug.cgi?id=1720987 here. The issue is that on the Windows 7/Classic Theme the OS-styled buttons everywhere changed the relative size some time in 2021-july
I finally run the mozregression and this fix (1715722) is the final answer of the tool
My session was to set ff versions window to 90-92 and look at the size of the Help button in the Page Info dialog.