1715742 - Improve our handling of undeleted files during profile deletion

Status: ASSIGNED

(Toolkit :: Startup and Profile System, task)

Description

[Jens Stutte [:jstutte]]

Bug 1714573 improved the deletion of the profile directory's content to happen before we unlock the profile. In doing so, we might end up with a list of undeleted files now (undeleted for whatever reasons, which might be outside of our control like antivirus or other scanners).

In order to reduce the potential for leaks further, we want to:

• retry their deletion after a short timeout for several times before giving up.
• report undeleted files always and enable a relative assertion

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1715742 - Remove special casing no longer necessary as Bug 1716291 was a duplicate of Bug 1546838 r=jstutte,nalexander

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1715742 - Post: Refactor `RemoveProfileFiles`; fix risk of factorial growth of undeleted files to remove. r=jstutte,nalexander

• Prefilter profile content so that each entry can be deleted recursively without checking for root or lockfiles.
• Store undeleted roots instead of undeleted files so that a deeply nested undeleted file don't result in factorial growth of files to delete.
• Make directory recursion generic so file deletion and undeleted file logging can traverse paths identically.

Comment 3

[Jens Stutte [:jstutte]]

Sorry, I think I lost this review out of sight...

Comment 4

[Jens Stutte [:jstutte]]

Patches are in "changes planned" status for now.