1715777 - Proton: DisableDeveloperTools policy doesn't get rid of developer tools anymore

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Mike Kaply [:mkaply]]

The DisableDeveloperTools policy by getting rid of the entire web developer menu.

We converted it to "More Tools" and renamed it, so the test still succeeded because it checked for a null menu.

But now all the menus are under More Tools.

All developer related items should be removed when this pref is set.

Web Developer Tools
Remote Debugging
Browser Console
Responsive Design Mode
Eyedropper
Extensions For Developer

Comment 1

[Mike Kaply [:mkaply]]

[Tracking Requested - why for this release]:

Requesting for 89 if we can get a small fix ready for next week.

This is a pretty serious problem for some customers. I wonder if this fix is small enough into the . release?

Emma, do you think there's a place where we could fix this pretty easily?

Comment 2

[Julien Cristau [:jcristau] (back April 22)]

pascal fyi

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Screenshot

It's getting rid of two items (Browser Toolbox and Browser Content Toolbox).

Need to figure out how to get rid of the west.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Bug 1715777 - Hide individual developer menuitems if devtools disabled by policy. r?emalysz?

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 9226568 [details]
Bug 1715777 - Hide individual developer menuitems if devtools disabled by policy. r?emalysz?

Beta/Release Uplift Approval Request

• User impact if declined: Enterprise users can access developer tools even though they have been turned off.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Turn on DisableDeveloperTools policy. Verify developers are gone from the more tools item.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a policy only patch, specifically gated around the pref.
• String changes made/needed:

Comment 6

[Mike Kaply [:mkaply]]

This was found in the field by customers, so I'd like go get it fixed asap.

Unfortunately there's no good way to write an automated test, but we're investigating.

It's a very safe patch, only happening if devtools is disabled and the query is gated with a default pref so it can't fail.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2747545d2ab2
Hide individual developer menuitems if devtools disabled by policy. r=emalysz?

Comment 8

[Mike Kaply [:mkaply]]

Attachment: Patch for release

Here is a complete patch for release that has a test and fixed one other small issue found.

Since the other patch is already in, I'll be adding these two new things in a separate patch.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2747545d2ab2

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/a15f3483af92

Comment 11

[Alin Ilea, Desktop QA]

Reproduced the issue in Beta 90.0b7 using Windows 10.
Verified - Fixed in Release 89.0.1 (build id: 20210614221319) and latest Nightly 91.0a1 (2021-06-14). All developer related items are removed when the DisableDeveloperTools policy is set.

Comment 12

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e4d318c8ad29

Comment 13

[Alin Ilea, Desktop QA]

Verified - Fixed in Beta 90.0b8 (build id: 20210615190254). Only Customize Toolbar, Task Manager and Page Source items are displayed in the More Tools submenu when the DisableDeveloperTools policy is set.