1715804 - Use enrollment branch information for startup onUpdate notifications

Status: VERIFIED FIXED

(Firefox :: Nimbus Desktop Client, defect, P1)

Description

[Andrei Oprea [:andreio]]

Enrollments don't have a featureIds property. The fix in bug 1714449 needs to be changed to use the branch feature information.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1715804 - Use enrollment branch information for startup onUpdate notifications

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bbe03437512
Use enrollment branch information for startup onUpdate notifications r=k88hudson

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4bbe03437512

Comment 4

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issue described in bug 1715500 is no longer reproducible. The issue in bug 1714304 is also verified as not reproducible anymore.
Please let me know if I should mark this issue as verified fixed based on this or if there is anything else needed.

Comment 5

[Andrei Oprea [:andreio]]

Comment on attachment 9226363 [details]
Bug 1715804 - Use enrollment branch information for startup onUpdate notifications

Beta/Release Uplift Approval Request

• User impact if declined: Affects planned experimentation in Firefox 90 bug 1715500
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Code only affects experimentation platform that is controlled from Remote Settings
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9226363 [details]
Bug 1715804 - Use enrollment branch information for startup onUpdate notifications

approved for 90.0b11

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9226363 [details]
Bug 1715804 - Use enrollment branch information for startup onUpdate notifications

Actually, no. This touches code added in bug 1714449 which is not in beta.

Comment 8

[Andrei Oprea [:andreio]]

Attachment: Bug 1715804 - Use enrollment branch information for startup onUpdate notifications

Comment 9

[Andrei Oprea [:andreio]]

Redid the patch for beta should be good now.

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9228551 [details]
Bug 1715804 - Use enrollment branch information for startup onUpdate notifications

thanks. should go in 90.0b12.

Comment 11

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/49fd84764e60

Comment 12

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issues described in bug 1715500 and bug 1714304 are not reproducible in Firefox Beta 90.0b12 (Build ID: 20210624190035) on Windows 10, macOS 11.1 and Linux Mint 20. As this is the fix for those issues, I am marking this as verified fixed.