1715902 - Refuse WebRender on Linux if GL context backed by software driver

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1715902 - Refuse WebRender on Linux if backed by software driver.

When trying to create a GLContextEGL or GLContextGLX, we should check to
see what our display is backed by. If using a software driver, we should
fail to create the context for WebRender, so that it can fallback to
Software WebRender.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c30c8b8dc0b5
Refuse WebRender on Linux if backed by software driver. r=jrmuizel

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1715902 - Refuse WebRender on Linux if backed by software driver.

Reject software rasterizers on Linux (except Software WebRender) when
trying to create full WebRender, unless WebRender was force enabled.

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset c30c8b8dc0b5 (bug 1715902) on Dev's request. CLOSED TREE

Backout:
https://hg.mozilla.org/integration/autoland/rev/8954c0ffd9dc3a6bfd9ed44261aed980101d5df2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df72cdfca682
Refuse WebRender on Linux if backed by software driver. r=jrmuizel

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9226515 [details]
Bug 1715902 - Refuse WebRender on Linux if backed by software driver.

Beta/Release Uplift Approval Request

• User impact if declined: Firefox will be slow for llvmpipe users who should have gotten SW-WR but instead got WR
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is only active on Linux, very small, worst case, it shifts some users from WR to SW-WR we didn't expect.
• String changes made/needed:

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/df72cdfca682

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9226515 [details]
Bug 1715902 - Refuse WebRender on Linux if backed by software driver.

Approved for 90 beta and our dot release, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/768b7bc3d4ca

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e3bf4bd5363

Comment 11

[Robert Mader [:rmader]]

Andrew, if I understand correctly this was targeted at 89 as we didn't want to backport both bug 1714897 and bug 1715245. For nightly/tip, this now duplicates functionality in gfxinfo, making it necessary to set two settings instead of one to enable WR on software drivers - shouldn't we get rid of that again?