Closed Bug 1715902 Opened 2 months ago Closed 2 months ago

Refuse WebRender on Linux if GL context backed by software driver

Categories

(Core :: Graphics: WebRender, defect, P2)

Desktop
Linux
defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox89 + fixed
firefox90 --- fixed
firefox91 --- fixed

People

(Reporter: aosmond, Assigned: aosmond, NeedInfo)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Summary: Refuse to create GLContextGLX and GLContextEGL on Linux if backed by software driver → Refuse WebRender on Linux if GL context backed by software driver

When trying to create a GLContextEGL or GLContextGLX, we should check to
see what our display is backed by. If using a software driver, we should
fail to create the context for WebRender, so that it can fallback to
Software WebRender.

Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c30c8b8dc0b5
Refuse WebRender on Linux if backed by software driver. r=jrmuizel

Reject software rasterizers on Linux (except Software WebRender) when
trying to create full WebRender, unless WebRender was force enabled.

Backed out changeset c30c8b8dc0b5 (bug 1715902) on Dev's request. CLOSED TREE

Backout:
https://hg.mozilla.org/integration/autoland/rev/8954c0ffd9dc3a6bfd9ed44261aed980101d5df2

Flags: needinfo?(aosmond)
Attachment #9226425 - Attachment is obsolete: true
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df72cdfca682
Refuse WebRender on Linux if backed by software driver. r=jrmuizel
Flags: needinfo?(aosmond)

Comment on attachment 9226515 [details]
Bug 1715902 - Refuse WebRender on Linux if backed by software driver.

Beta/Release Uplift Approval Request

  • User impact if declined: Firefox will be slow for llvmpipe users who should have gotten SW-WR but instead got WR
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It is only active on Linux, very small, worst case, it shifts some users from WR to SW-WR we didn't expect.
  • String changes made/needed:
Attachment #9226515 - Flags: approval-mozilla-release?
Attachment #9226515 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Comment on attachment 9226515 [details]
Bug 1715902 - Refuse WebRender on Linux if backed by software driver.

Approved for 90 beta and our dot release, thanks.

Attachment #9226515 - Flags: approval-mozilla-release?
Attachment #9226515 - Flags: approval-mozilla-release+
Attachment #9226515 - Flags: approval-mozilla-beta?
Attachment #9226515 - Flags: approval-mozilla-beta+

Andrew, if I understand correctly this was targeted at 89 as we didn't want to backport both bug 1714897 and bug 1715245. For nightly/tip, this now duplicates functionality in gfxinfo, making it necessary to set two settings instead of one to enable WR on software drivers - shouldn't we get rid of that again?

Flags: needinfo?(aosmond)
You need to log in before you can comment on or make changes to this bug.