1715904 - Use DOCUMENT_EVENT's will-navigate event in all tests

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1712592 introduced DOCUMENT_EVENT will-navigate resource in order to replace target's will-navigate event.
Many tests are still listening to target actor's will-navigate,
they should instead listen ot DOCUMENT_EVENT will-navigate which is more resilient when a cross process navigation / target switching happens.

This blocks bug 1698891, as server side targets stop emitting will-navigate.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1715904 - [devtools] Move waitForNextResource from test helper to ResourceCommand.

This can actually be helpful also in production.
See netmonitor's connector and TargetCommand.reload.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1715904 - [devtools] Refactor test to use DOCUMENT_EVENT's will-navigate.

I'm wondering if we should have yet another helper, like TargetCommand.waitForNextWillNavigate,
which would be a wrapper around waitForNextResource ?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f9522b3c4c8
[devtools] Move waitForNextResource from test helper to ResourceCommand. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2b1d4ef5f3ea
[devtools] Refactor test to use DOCUMENT_EVENT's will-navigate. r=nchevobbe

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8f9522b3c4c8
https://hg.mozilla.org/mozilla-central/rev/2b1d4ef5f3ea