Closed Bug 1715906 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29336 - WebXR: fix regression in obtaining pose between targetRay and grip space

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox91 fixed)

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29336 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29336
Details from upstream follow.

b'Piotr Bialecki <bialpio@chromium.org>' wrote:

WebXR: fix regression in obtaining pose between targetRay and grip space

Introduces a change to native origins to be able to distinguish between
input-source-derived grip space origin and target ray space origin.
Since the native origins of those 2 spaces were identical, the change
introduced in https://crrev.com/c/2803481 caused them to be treated as
the same space, thus resulting in returning identity pose from
XRFrame::getPose() method.

Also adds a WPT test that would've caught this regression.

Other minor changes:

  • converted if-elseif-else chain into a switch statement

Fixed: 1214497
Change-Id: I66e18b863b2769fce6c8126b5d0ddade99fe9b25
Reviewed-on: https://chromium-review.googlesource.com/2953960
WPT-Export-Revision: dac6ac488e412f4617c4cca7f03387d00082b3ce

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/xrInputSource_getPose_targetRay_grip.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
Poses between targetRaySpace and gripSpace can be obtained and behave correctly - webgl: FAIL (Chrome: FAIL, Safari: FAIL)
Poses between targetRaySpace and gripSpace can be obtained and behave correctly - webgl2: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webxr/xrInputSource_getPose_targetRay_grip.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd3fe16d16b7
[wpt PR 29336] - WebXR: fix regression in obtaining pose between targetRay and grip space, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9d1844e9d44f
[wpt PR 29336] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/dd3fe16d16b7
https://hg.mozilla.org/mozilla-central/rev/9d1844e9d44f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.