1715908 - Use DOCUMENT_EVENT's dom-complete event in the target legacy listeners

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Target legacy listeners is still using the target event and should use the resource instead, which is more resilient with cross process navigation.

https://searchfox.org/mozilla-central/search?q=%22navigate%22&path=devtools%2Fshared%2Fcommands&case=false&regexp=false

Comment 1

[Alexandre Poirot [:ochameau]]

Note that bug 1691585 also require some tweaks around this legacy listener.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1715908 - [devtools] Replace usage of navigate with DOCUMENT_EVENT dom-loading resource in service worker legacy listener. r=ochameau.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24558d007063
[devtools] Replace usage of navigate with DOCUMENT_EVENT dom-loading resource in service worker legacy listener. r=ochameau.

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 24558d007063 (Bug 1715908) for causing dt failures in browser_target_list_service_workers_navigation.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/a7f870ec7f087482d26663f05492badaa9f29bb1
Push with failures, failure log.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

I'm looking at it now

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1715908 - [devtools] Flush resources on dom-loading.r=ochameau.

This fixes intermittent failures on browser_target_list_service_workers_navigation.js
that were appearing with the next patch on the queue (switching to dom-loading resource
in legacy service worker watcher).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77a1ad06b34b
[devtools] Flush resources on dom-loading.r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/df625fb8e038
[devtools] Replace usage of navigate with DOCUMENT_EVENT dom-loading resource in service worker legacy listener. r=ochameau.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/77a1ad06b34b
https://hg.mozilla.org/mozilla-central/rev/df625fb8e038