Closed Bug 1715908 Opened 3 years ago Closed 3 years ago

Use DOCUMENT_EVENT's dom-complete event in the target legacy listeners

Categories

(DevTools :: Framework, task)

task

Tracking

(Fission Milestone:MVP, firefox92 fixed)

RESOLVED FIXED
92 Branch
Fission Milestone MVP
Tracking Status
firefox92 --- fixed

People

(Reporter: ochameau, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(2 files)

Target legacy listeners is still using the target event and should use the resource instead, which is more resilient with cross process navigation.

https://searchfox.org/mozilla-central/search?q=%22navigate%22&path=devtools%2Fshared%2Fcommands&case=false&regexp=false

Summary: Use DOCUMENT_EVENT's navigate event in the target legacy listeners → Use DOCUMENT_EVENT's dom-complete event in the target legacy listeners
Fission Milestone: --- → M8
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp

Note that bug 1691585 also require some tweaks around this legacy listener.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Attachment #9228677 - Attachment description: Bug 1715908 - [devtools] use DOCUMENT_EVENT dom-complete resource in target legacy listener. r=ochameau. → Bug 1715908 - [devtools] Replace usage of navigate with DOCUMENT_EVENT dom-loading resource in service worker legacy listener. r=ochameau.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24558d007063
[devtools] Replace usage of navigate with DOCUMENT_EVENT dom-loading resource in service worker legacy listener. r=ochameau.

Backed out changeset 24558d007063 (Bug 1715908) for causing dt failures in browser_target_list_service_workers_navigation.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/a7f870ec7f087482d26663f05492badaa9f29bb1
Push with failures, failure log.

Flags: needinfo?(nchevobbe)

I'm looking at it now

Flags: needinfo?(nchevobbe)
Fission Milestone: M8 → MVP

This fixes intermittent failures on browser_target_list_service_workers_navigation.js
that were appearing with the next patch on the queue (switching to dom-loading resource
in legacy service worker watcher).

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77a1ad06b34b
[devtools] Flush resources on dom-loading.r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/df625fb8e038
[devtools] Replace usage of navigate with DOCUMENT_EVENT dom-loading resource in service worker legacy listener. r=ochameau.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.