1715979 - DateTimePatternGenerator and Enumeration move assignment operator leaks

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P1)

Description

[André Bargull [:anba]]

Enumeration& operator=(Enumeration&& other) noexcept {
  if (this != &other) {
    mUEnumeration = other.mUEnumeration;
    other.mUEnumeration = nullptr;
  }
}

The operator should call uenum_close before the assignment mUEnumeration = other.mUEnumeration.

A similar issue is present in DateTimePatternGenerator.

Comment 1

[Greg Tatum [:gregtatum]]

I don't think this is correct. Why would uenum_close be called when the pointer is being moved to another owner? The resource's ownership is being moved, and shouldn't be closed. Closing the resource, then transferring it to a new owner would cause a crash when the resource is then used.

Comment 2

[André Bargull [:anba]]

this->mUEnumeration should be closed before it's overwritten with other.mUEnumeration, right?

Comment 3

[Greg Tatum [:gregtatum]]

Ah, I investigated this more, and yes you are correct. I don't think the current implementation leaks, but future uses can. This should be fixed.

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1715979 - Do not leak ICU objects in mozilla:intl component moves; r?nordzilla

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caa6a6bbe97d
Do not leak ICU objects in mozilla:intl component moves; r=nordzilla

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/caa6a6bbe97d