1715988 - Filtering with incomplete status-code should treat the filter input as "includes", not "equals"

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open a data:text/html,<meta charset=utf8> tab
2. Open devtools, select the netmonitor, and open the split console
3. Evaluate

fetch("https://httpstat.us/400")
fetch("https://httpstat.us/403")
fetch("https://httpstat.us/404")

to populate the netmonitor

4. In the netmonitor filter input, type status-code:4

Expected results

All the request with status code starting with 4 are displayed (so all the 3 network calls here)

Actual results

No requests are displayed

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

I think this is where the filtering happens: https://searchfox.org/mozilla-central/rev/af8e5d37fd56be90ccddae2203e7b875d3f3ae87/devtools/client/netmonitor/src/utils/filter-text-utils.js#146

So instead of having the equal, we could use a startsWith call

Comment 2

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting!
Looks like a good first bug.

Comment 3

[Claudia Batista [:claubatista]]

Hi! I was able to reproduce the crash.
I'd like to work on this bug. :)

Comment 4

[Hubert Boma Manilla (:bomsy)]

Go ahead!
Assigned to you!

Thanks.

Comment 5

[Claudia Batista [:claubatista]]

Attachment: Bug 1715988 - [devtools] Match incomplete search terms in status-code:search. r=bomsy

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24f721024e86
[devtools] Match incomplete search terms in status-code:search. r=nchevobbe

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/24f721024e86