Closed Bug 1716036 Opened 1 year ago Closed 1 year ago

static destructors in nsThread

Categories

(Core :: XPCOM, defect)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

The "magic static" objects created in nsThread::ThreadList and nsThread::ThreadListMutex have non-trivial destructors, so they end up setting atexit hooks.

I'd like to switch these over to be StaticLocalAutoPtrs which were added specifically for the purpose of ensuring trivial destructors for magic statics.

The "magic static" objects created in nsThread::ThreadList and
nsThread::ThreadListMutex have non-trivial destructors, so they end up
setting atexit hooks.

I'd like to switch these over to be StaticLocalAutoPtrs which were added
specifically for the purpose of holding magic statics, and have trivial
destructors.

Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ea8353218d0
Use StaticLocalAutoPtr for magic statics in nsThread; r=KrisWright
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.