Closed Bug 1716036 Opened 2 years ago Closed 2 years ago

static destructors in nsThread

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1716036: Use StaticLocalAutoPtr for magic statics in nsThread; r=#xpcom-reviewers
48 bytes, text/x-phabricator-request
Details | Review

The "magic static" objects created in nsThread::ThreadList and nsThread::ThreadListMutex have non-trivial destructors, so they end up setting atexit hooks.

I'd like to switch these over to be StaticLocalAutoPtrs which were added specifically for the purpose of ensuring trivial destructors for magic statics.

The "magic static" objects created in nsThread::ThreadList and
nsThread::ThreadListMutex have non-trivial destructors, so they end up
setting atexit hooks.

I'd like to switch these over to be StaticLocalAutoPtrs which were added
specifically for the purpose of holding magic statics, and have trivial
destructors.

Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ea8353218d0
Use StaticLocalAutoPtr for magic statics in nsThread; r=KrisWright

https://hg.mozilla.org/mozilla-central/rev/4ea8353218d0

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.