1716036 - static destructors in nsThread

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

The "magic static" objects created in nsThread::ThreadList and nsThread::ThreadListMutex have non-trivial destructors, so they end up setting atexit hooks.

I'd like to switch these over to be StaticLocalAutoPtrs which were added specifically for the purpose of ensuring trivial destructors for magic statics.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1716036: Use StaticLocalAutoPtr for magic statics in nsThread; r=#xpcom-reviewers

The "magic static" objects created in nsThread::ThreadList and
nsThread::ThreadListMutex have non-trivial destructors, so they end up
setting atexit hooks.

I'd like to switch these over to be StaticLocalAutoPtrs which were added
specifically for the purpose of holding magic statics, and have trivial
destructors.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ea8353218d0
Use StaticLocalAutoPtr for magic statics in nsThread; r=KrisWright

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4ea8353218d0