1716044 - Fix WebGL in combination with compositor integration

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Robert Mader [:rmader]]

It's currently broken for some reason.

Comment 1

[Robert Mader [:rmader]]

Glenn, do have any idea if there's something special going on in WR wrt WebGL? I thought this already worked, but apparently doesn't. Do contents get blit somewhere, or do we somehow try to directly import WebGL buffers into a tile or so?

Comment 2

[Robert Mader [:rmader]]

Never mind, apparently just a bug in the clipping logic in NativeLayerRootWayland :)

Comment 3

[Robert Mader [:rmader]]

So the issue here is that WebGL content apparently is treated Y-flipped within WR:

• the transformation matrix is either flipped or just transformed by the height of the layer, not sure yet
• content is y-flipped

Unfortunately RenderCompositorNative does not let us know about it - and I don't yet understand how NativeLayerCA figures this out. Glenn, does this ring any bell for you, that WebGL apparently gets treated differently in WR concerning coordinates / y-flipp?

Comment 4

[Robert Mader [:rmader]]

Never mind and sorry for the noise! Stupid me just didn't handle y-flips in the transform matrix

Comment 5

[Robert Mader [:rmader]]

Attachment: Bug 1716044 - Handle Y-flipped transform matrices, r=#gfx-reviewers

This caused e.g. WebGL content to get hidden as it always fell out
of bounds. As a side effect clean up the whole custom transform math.

Depends on D118274

Comment 6

[Robert Mader [:rmader]]

https://treeherder.mozilla.org/jobs?repo=try&revision=253f62f0f47b2349bab9134b447614e75dd8cea7

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e12a4e3c04b9
Handle Y-flipped transform matrices, r=gfx-reviewers,lsalzman

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e12a4e3c04b9