1716069 - "The page isn't redirecting properly" error is received on www.animechiby.com because of https-rr

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Ksenia Berezina [:ksenia] on leave until 09/15]

This was initially reported in https://github.com/webcompat/web-bugs/issues/76013

STR:
Visit http://www.animechiby.com/ in Firefox Nightly 91.0a1 (2021-06-10) and observe the site

Expected:
http version of the site loads

Actual:
Endless loop with an attempt to redirect to https, which site doesn't support

I was able to reproduce this issue on macOS and the original reporter is on Linux

Comment 1

[Ksenia Berezina [:ksenia] on leave until 09/15]

Similar issue in https://github.com/webcompat/web-bugs/issues/75779 with this site http://wormax.io/

Comment 2

[Daniel Veditz [:dveditz]]

This happens with or without HTTPS-only mode turned on so it's more Networking than "DOM: Security". However what I see (even with a cleared cache, so no cached 302s) is that the site redirects to https:, then the https version redirects back to http, and so on in a loop.

Does not happen on Safari or Chrome. This really looks like something the site itself is doing, but I don't know why they would single Firefox out.

Comment 3

[Daniel Veditz [:dveditz]]

Same looping behavior with http://wormax.io/ even with https-only turned off.

Comment 4

[Kershaw Chang [:kershaw]]

The HTTPS upgrade is caused by HTTPS RR. I'll take a look.

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1716069 - P1: Do a proper check for endless upgrade and downgrade look for HTTPS RR, r=dragana

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1716069 - P2: Set NS_HTTP_DISALLOW_HTTPS_RR when upgrade with HTTPS RR is skipped, r=dragana

Depends on D118013

Comment 7

[Kershaw Chang [:kershaw]]

Attachment: Bug 1716069 - P1: Skip user gesture check in IsUpgradeDowngradeEndlessLoop(), r=ckerschb

Comment 8

[Kershaw Chang [:kershaw]]

Attachment: Bug 1716069 - P2: Use nsHTTPSOnlyUtils::IsUpgradeDowngradeEndlessLoop to check if there is an endless loop when HTTPS RR is presented, r=ckerschb

Depends on D118598

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c9774f5b0bc
P1: Skip user gesture check in IsUpgradeDowngradeEndlessLoop(), r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/60d705792e3a
P2: Use nsHTTPSOnlyUtils::IsUpgradeDowngradeEndlessLoop to check if there is an endless loop when HTTPS RR is presented, r=ckerschb

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9c9774f5b0bc
https://hg.mozilla.org/mozilla-central/rev/60d705792e3a