Closed Bug 1716232 Opened 4 months ago Closed 3 months ago

Add networks editor to cZ

Categories

(SeaMonkey :: Chat, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.88
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Whiteboard: SM2.53.9)

Attachments

(1 file, 3 obsolete files)

At the moment the only way to add networks is to create a networks.txt file and put into your profile directory in the chatzilla subdirectory. See http://chatzilla.hacksrus.com/faq/#networks for more details.
Massively rewritten but inspired by:
https://github.com/Ascrod/ambassador/commit/e53f0bc93f45f9ce198d39f765e48740c260f93b
https://github.com/Ascrod/ambassador/commit/89211db54328233229cd879d0480f541aab25faa

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: No way to edit IRC networks within cZ
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 1 updated, 59 new

Attachment #9226710 - Flags: review?(frgrahl)
Attachment #9226710 - Flags: approval-comm-release?
Attachment #9226710 - Flags: approval-comm-esr60?

Fixed issue with selecting libera.chat when editing any of its servers.
Added "Server" to the server buttons
Changed the css to set a minimum size on serverList rather than serverListBox.
Made the default size of the network editor slightly wider to accommodate the wider server buttons.

Attachment #9226710 - Attachment is obsolete: true
Attachment #9226710 - Flags: review?(frgrahl)
Attachment #9226710 - Flags: approval-comm-release?
Attachment #9226710 - Flags: approval-comm-esr60?
Attachment #9227287 - Flags: review?(frgrahl)
Attachment #9227287 - Flags: approval-comm-release?
Attachment #9227287 - Flags: approval-comm-esr60?

Switched to using Move Up / Down buttons rather than a Set Default button

Attachment #9227287 - Attachment is obsolete: true
Attachment #9227287 - Flags: review?(frgrahl)
Attachment #9227287 - Flags: approval-comm-release?
Attachment #9227287 - Flags: approval-comm-esr60?
Attachment #9228010 - Flags: review?(frgrahl)
Attachment #9228010 - Flags: approval-comm-release?
Attachment #9228010 - Flags: approval-comm-esr60?

Comment on attachment 9228010 [details] [diff] [review]
1716232-irc-networks-editor-v1_2-2539.patch

LGTM

Possible NITS

+<!ENTITY serverDetails.label "Details of selected server:">

Should this be "Details of the selected server" or "Selected server details"?

  • <tooltip id="czNetworkTip"
  •       orient="vertical"
    
  •       onpopupshowing="return gNetworkWindow.onTooltipPopupShowing(this);"> 
    
  • <vbox>
  •  <label id="czNetworkTipTitle" class="header">.</label>
    
  •  <label id="czNetworkTipLabel">.</label>
    
  • </vbox>
  • <spacer flex="1"/>
  • </tooltip>

Is this used somewhere?

Attachment #9228010 - Flags: review?(frgrahl)
Attachment #9228010 - Flags: review+
Attachment #9228010 - Flags: approval-comm-release?
Attachment #9228010 - Flags: approval-comm-release+
Attachment #9228010 - Flags: approval-comm-esr60?
Attachment #9228010 - Flags: approval-comm-esr60+

[Triage Comment]
Remove unused tooltip xul code
Fixed ServerDetails.label
Carrying forward r/a

Attachment #9228010 - Attachment is obsolete: true
Attachment #9230562 - Flags: review+
Attachment #9230562 - Flags: approval-comm-release+
Attachment #9230562 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/bf565da9bd28
Add networks editor to cZ. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Whiteboard: SM2.53.9
Target Milestone: --- → seamonkey 2.88
You need to log in before you can comment on or make changes to this bug.