1716232 - Add networks editor to cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

At the moment the only way to add networks is to create a networks.txt file and put into your profile directory in the chatzilla subdirectory. See http://chatzilla.hacksrus.com/faq/#networks for more details.
Massively rewritten but inspired by:
https://github.com/Ascrod/ambassador/commit/e53f0bc93f45f9ce198d39f765e48740c260f93b
https://github.com/Ascrod/ambassador/commit/89211db54328233229cd879d0480f541aab25faa

Comment 1

[Ian Neal]

Attachment: 1716232-irc-networks-editor-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: No way to edit IRC networks within cZ
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 1 updated, 59 new

Comment 2

[Ian Neal]

Attachment: 1716232-irc-networks-editor-v1_1-2539.patch

Fixed issue with selecting libera.chat when editing any of its servers.
Added "Server" to the server buttons
Changed the css to set a minimum size on serverList rather than serverListBox.
Made the default size of the network editor slightly wider to accommodate the wider server buttons.

Comment 3

[Ian Neal]

Attachment: 1716232-irc-networks-editor-v1_2-2539.patch

Switched to using Move Up / Down buttons rather than a Set Default button

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9228010 [details] [diff] [review]
1716232-irc-networks-editor-v1_2-2539.patch

LGTM

Possible NITS

+<!ENTITY serverDetails.label "Details of selected server:">

Should this be "Details of the selected server" or "Selected server details"?

• <tooltip id="czNetworkTip"

•       orient="vertical"
  

•       onpopupshowing="return gNetworkWindow.onTooltipPopupShowing(this);"> 
  

• <vbox>

•  <label id="czNetworkTipTitle" class="header">.</label>
  

•  <label id="czNetworkTipLabel">.</label>
  

• </vbox>
• <spacer flex="1"/>
• </tooltip>

Is this used somewhere?

Comment 5

[Ian Neal]

Attachment: 1716232-irc-networks-editor-v1_3-2539.patch

[Triage Comment]
Remove unused tooltip xul code
Fixed ServerDetails.label
Carrying forward r/a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf565da9bd28
Add networks editor to cZ. r=frg

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/2b074834eea3815cb999af9d4c1d7b84a78bfda0
Add networks editor to cZ. r=frg a=frg