1716235 - value of 'Key size' dropdown for OpenPGP key generation should not be cropped

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: key size cropped

Thunderbird 91.0a1 in Windows 8.1

The dropdown showing the key size in the dialog to generate a new OpenPGP key pair is cropped (opening it shows the full values). It shouldn't be cropped.

Comment 1

[Magnus Melin [:mkmelin]]

Not cropped over here on linux.
But I don't have the down arrows...

Comment 2

[Magnus Melin [:mkmelin]]

Hmm, actually where did those arrows go... seems to be missing everywhere.

Comment 3

[Richard Marti (:Paenglab)]

Nothing missing here, checked on Linux too. You're on tip of M-C and C-C?

Comment 4

[Richard Marti (:Paenglab)]

The screenshot looks like opened from OpenPGP Key Manager and not in Account Manager. Tried this with the German locale and nothing is cropped. Maybe Sebastian uses a scaled desktop which could give issues with this menupopups on normal dialogs.

Comment 5

[Magnus Melin [:mkmelin]]

(I was l(In reply to Richard Marti (:Paenglab) from comment #3)

Nothing missing here, checked on Linux too. You're on tip of M-C and C-C?

This was the problem for me...

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1716235-keySize-width.patch

I gave the menulist a width to show always the whole content. 6em doesn't look too wide.

Comment 7

[Magnus Melin [:mkmelin]]

@aryx, are you using a scaled desktop or something similar that could cause this?

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The OS level zoom is 125%, issue persists with latest Daily.

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9229539 [details] [diff] [review]
1716235-keySize-width.patch

Review of attachment 9229539 [details] [diff] [review]:
-----------------------------------------------------------------

I guess. But this shouldn't really be needed, and I don't understand why this particular case would need it and other cases around the app wouldn't.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/091d87c96684
Make the keySize menulist a bit wider. r=mkmelin

Comment 11

[Richard Marti (:Paenglab)]

Comment on attachment 9229539 [details] [diff] [review]
1716235-keySize-width.patch

[Approval Request Comment]
User impact if declined: possibility of cropped text in the key size menulist with higher desktop scaling
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9229539 [details] [diff] [review]
1716235-keySize-width.patch

[Triage Comment]
Approved for beta

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b7a1ff668f8e