1716299 - Use of unknown property Ci.nsIDocumentEncoder.OutRaw in test_nsIEditor_outputToString.html

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Mark Banner (:standard8)]

Bug 1713867 added test_nsIEditor_outputToString.html, we have a manually (at the moment) run eslint rule that has picked up the following:

editor/libeditor/tests/test_nsIEditor_outputToString.html
   32:51  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
   38:51  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
   44:51  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
   53:51  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
   59:51  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
   65:51  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
   85:56  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
   91:56  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
   97:56  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
  105:56  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
  111:56  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)
  117:56  error  Use of unknown property Ci.nsIDocumentEncoder.OutRaw  mozilla/ci-checks (eslint)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Thanks, I wonder, why it was not detected by the treeherder's jobs.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Bug 1716299 - Fix the flag name r=m_kato!

nsIDocumentEncoder.OutputRaw was misspelled as nsIDocumentEncoder.OutRaw.

Then, I investigate the expected result more. Then, I see that when only this
flag is set, any markups should be ignored except <br>. Therefore, I modified
the 2 test results which check <p>, <div> and <br> elements.

Comment 3

[Mark Banner (:standard8)]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #1)

Thanks, I wonder, why it was not detected by the treeherder's jobs.

The rule is a manually run ESLint one, as it depends on build output, and we haven't got around to setting up a specific job for it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a69837f13d9
Fix the flag name r=m_kato

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0a69837f13d9