Use of unknown property Ci.mozIExtensionAPIRequestResult.RESULT_VALUE in test_ext_webidl_runtime_port.js
Categories
(WebExtensions :: General, defect, P1)
Tracking
(firefox-esr78 unaffected, firefox89 unaffected, firefox90 unaffected, firefox91 fixed)
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox89 | --- | unaffected |
firefox90 | --- | unaffected |
firefox91 | --- | fixed |
People
(Reporter: standard8, Assigned: rpl)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Bug 1682632 added test_ext_webidl_runtime_port.js, we have a manually (at the moment) run eslint rule that has picked up the following:
toolkit/components/extensions/test/xpcshell/webidl-api/test_ext_webidl_runtime_port.js
95:19 error Use of unknown property Ci.mozIExtensionAPIRequestResult.RESULT_VALUE mozilla/ci-checks (eslint)
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Ci.mozIExtensionAPIRequestResult.RESULT_VALUE
was actually meant to be Ci.mozIExtensionAPIRequestResult.RETURN_VALUE
(which is the enum actually defined in the idl file as a cenum).
It used to be named RESULT_VALUE in a older version of those patches, I missed to notice it because that part of the test is expected to trigger an error, returning the unknown RESULT_VALUE does still trigger the error but it was meant to trigger the error because the value returned doesn't contain the property expected by a (ExtensionPortDescription
webIDL dictionary)[https://searchfox.org/mozilla-central/rev/bea2345ce636dc329ac7133fc0a13c9171777e40/dom/webidl/ExtensionPort.webidl#36-39].
The attached patch fixed the typo, and I have verified locally that the test still pass as expected.
Updated•3 years ago
|
Comment 3•3 years ago
|
||
Set release status flags based on info from the regressing bug 1682632
Assignee | ||
Updated•3 years ago
|
Comment 5•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Description
•