Closed Bug 1716340 Opened 8 months ago Closed 4 months ago

GIFFT's codegen should assert a one-to-one relationship between metric and mirrored probe

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: chutten, Assigned: chutten)

References

Details

(Whiteboard: [telemetry:fog:m?])

Attachments

(1 file)

Right now you can mirror two metrics to the same probe (see https://phabricator.services.mozilla.com/D117420#change-71vUbTBlPECr ). This is probably not a good thing to permit (it's likely a sign of some copypasta gone wrong), so we should catch this at codegen time.

This'd be a good one to get to before FOG Migration starts in earnest.

Assignee: nobody → chutten
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [telemetry:fog:m?]

The code was already trying to do this but was comparing tuples instead of
mirror probe names. Guess it got missed in a refactor.

Amusingly I was violating the invariant in two places and had to fix 'em : |

Attachment #9244350 - Attachment description: Bug 1716340 - GIFF codegen should enforce no more than 1 metric may mirror to any probe r?janerik! → Bug 1716340 - GIFFT codegen should enforce no more than 1 metric may mirror to any probe r?janerik!
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b485b19d9e0
GIFFT codegen should enforce no more than 1 metric may mirror to any probe r=janerik
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Regressions: 1734493
You need to log in before you can comment on or make changes to this bug.