Closed Bug 1716390 Opened 3 years ago Closed 1 years ago

Tooltool should use Python 3

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1809588

People

(Reporter: mhentges, Unassigned)

References

Details

As beautifully pointed out by :callek here, tooltool still uses Python 2 in some cases.

We should adjust these to use Python 3 as well.

Blocks: 1714688

Since tooltool.py already supports Python 3, this should just be a straight s/python2.7/python3.

I will note that tooltool.py is vendored code. So removing the PY2 code path means that we diverge from upstream. So another way to unblock bug 1714688 is to leave that file alone for now.

No longer blocks: 1714688

Just came here to comment the same about tooltool.py vendored code but Andrew is fast, I pushed to try a little ago, lets see how it goes https://treeherder.mozilla.org/jobs?repo=try&revision=815c44877a029f2ad5c8c39b995404dfc5ba3b80 ;)

Another try with just py2 > py3 change https://treeherder.mozilla.org/jobs?repo=try&revision=321b211d2419dc0d0e4bc6199c8f1c6ee6b39295&selectedTaskRun=JtFZHUcnSiiEj_lM1QGWBw.0

Just noticed that python/mozbuild/mozbuild/action/tooltool.py in tree still has a python bangline... on OS X 12 monterey python(2) isn't installed any longer. Changing it to python3 worked for me.

Status: NEW → RESOLVED
Closed: 1 years ago
Duplicate of bug: 1809588
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.