1716404 - Fix dom/base/test/test_bug1406102.html test skipped in 'dom/base/test/mochitest.ini' for fission xorigin

Status: RESOLVED FIXED

(Core :: Layout, task, P2)

Description

[Andrew Halberstadt [:ahal]]

Note: This bug was filed automatically via script.

The following tests are being disabled in dom/base/test/mochitest.ini due to new fission xorigin platform triage:

• test_bug1406102.html

Full diff:

diff --git a/dom/base/test/mochitest.ini b/dom/base/test/mochitest.ini
--- a/dom/base/test/mochitest.ini
+++ b/dom/base/test/mochitest.ini
@@ -593,16 +593,18 @@ support-files = file_bug1100912.html
 [test_bug1308069.html]
 [test_bug1314032.html]
 [test_bug1318303.html]
 [test_bug1375050.html]
 [test_bug1381710.html]
 [test_bug1399605.html]
 [test_bug1404385.html]
 [test_bug1406102.html]
+skip-if =
+  fission && xorigin  # {bug} - New fission platform triage
 [test_bug1421568.html]
 [test_bug1472427.html]
 [test_bug1499169.html]
 skip-if = toolkit == 'android' # Timeouts on android due to page closing issues with embedded pdf
 [test_bug1576154.html]
 [test_bug1640766.html]
 support-files =
   iframe1_bug1640766.html

See this try push for failures. If failures are missing, they were
either discovered on a subsequent try push or this bug is invalid.

To run these failures in your own try push, first ensure the patches from bug 1700781
have landed, revert the skip-if annotations, then run:

$ ./mach try fuzzy --rebuild 3 dom/base/test/mochitest.ini

Finally use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s).

Disclaimer

Adding new platforms is not an exact science, and in order to get to green and
enable coverage ASAP, we often err on the side of disabling when in doubt. For
this reason, it's possible that the annotation was added in error, is covered
by an existing intermittent, or was fixed sometime between now and when the
annotation was made.

If you believe this is the case here, please feel free to remove the
annotation. Sorry for the inconvenience and thanks for understanding.

Comment 1

[Chris Peterson [:cpeterson]]

I think this failure is Fission bug 1671539, which was resolved "fixed" without a known fix. I will reopen that bug.

TEST-UNEXPECTED-FAIL | dom/base/test/test_bug1406102.html | intersectionRatio should be greater than zero

This test_bug1406102.html test is now disabled for fission+xorigin mode on all platforms:

[test_bug1406102.html]
skip-if =
  fission && xorigin  # Bug 1716404 - New fission platform triage

https://searchfox.org/mozilla-central/rev/5e955a47c4af398e2a859b34056017764e7a2252/dom/base/test/mochitest.ini#600-602

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

The test is about IntersectionObserver. Layout might be a better component.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

I've finished writing the fix;
https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=e_e7ChwfT7aVtRMPxeA1xA.0&revision=8a1913547abb217629513801a5465284ea4954a0

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1716404 - Use BrowserChild's visible rect in BrowserChild::GetTopLevelViewportVisibleRectInSelfCoords as a fallback value if we haven't received transform information from APZ. r?emilio

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1716404 - Enable test_bug1406102.html on fis-xorig runs. r?emilio

Depends on D118779

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1716404 - Stop processing IntersectionObserver update if we haven't enough information in OOP iframes. r?emilio

Once after we got the transform matrix for the OOP iframe from APZ, we trigger
the update process[1] via the refresh driver so that we can ensure invoking
IntersectionObserver callbacks in OOP iframe when it gets initially painted.

[1] https://searchfox.org/mozilla-central/rev/3ba42a92cea3e61163091e7fe4d22bcda74a1e5a/dom/ipc/BrowserChild.cpp#1325

Comment 7

[Chris Peterson [:cpeterson]]

Rolling over the remaining Fission M7a bugs to the Fission M8 milestone.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1716404 - Allow zero intersectionRatio in bug1406102.html. r?emilio

It's okay that we'd end up firing non-zero intersectionRatio records.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aab3ebb7aa7
Allow zero intersectionRatio in bug1406102.html. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c70dac69ebe0
Enable test_bug1406102.html on fis-xorig runs. r=emilio

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7aab3ebb7aa7
https://hg.mozilla.org/mozilla-central/rev/c70dac69ebe0