1716408 - Fix editor/libeditor/tests/test_cut_copy_password.html test skipped in 'editor/libeditor/tests/mochitest.ini' for fission xorigin

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Andrew Halberstadt [:ahal]]

Note: This bug was filed automatically via script.

The following tests are being disabled in editor/libeditor/tests/mochitest.ini due to new fission xorigin platform triage:

• test_cut_copy_password.html

Full diff:

diff --git a/editor/libeditor/tests/mochitest.ini b/editor/libeditor/tests/mochitest.ini
--- a/editor/libeditor/tests/mochitest.ini
+++ b/editor/libeditor/tests/mochitest.ini
@@ -247,16 +247,18 @@ skip-if =
 [test_caret_move_in_vertical_content.html]
 [test_CF_HTML_clipboard.html]
 skip-if = os != 'mac' # bug 574005
 [test_cmd_fontFace_with_tt.html]
 [test_composition_event_created_in_chrome.html]
 [test_contenteditable_focus.html]
 [test_cut_copy_delete_command_enabled.html]
 [test_cut_copy_password.html]
+skip-if =
+  fission && xorigin && os == "win" && !debug  # {bug} - New fission platform triage
 [test_dom_input_event_on_htmleditor.html]
 [test_dom_input_event_on_texteditor.html]
 [test_dragdrop.html]
 skip-if = os == 'android'
 [test_handle_new_lines.html]
 [test_initial_selection_and_caret_of_designMode.html]
 [test_inline_style_cache.html]
 [test_inlineTableEditing.html]

See this try push for failures. If failures are missing, they were
either discovered on a subsequent try push or this bug is invalid.

To run these failures in your own try push, first ensure the patches from bug 1700781
have landed, revert the skip-if annotations, then run:

$ ./mach try fuzzy --rebuild 3 editor/libeditor/tests/mochitest.ini

Finally use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s).

Disclaimer

Adding new platforms is not an exact science, and in order to get to green and
enable coverage ASAP, we often err on the side of disabling when in doubt. For
this reason, it's possible that the annotation was added in error, is covered
by an existing intermittent, or was fixed sometime between now and when the
annotation was made.

If you believe this is the case here, please feel free to remove the
annotation. Sorry for the inconvenience and thanks for understanding.

Comment 1

[Chris Peterson [:cpeterson]]

Masayuki, this Editor test failure with Fission (in xorigin mode). Do you think this fixing this test should block shipping Fission MVP?

This failure might be a duplicate of bug 1676702, which happens for both Fission and non-Fission. So this failure doesn't sound like a high-priority bug for Fission (unless Fission makes the failure more frequent).

TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_cut_copy_password.html | Timed out while polling clipboard for requested data, got: waitForClipboard-known-value-0.9470221515915785

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, I don't think that this should block Fission because the feature being tested is currently used only in chrome UI (password manager). I guess that the original issue of this intermittent failure is in the test framework side or test itself.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #2)

Yeah, I don't think that this should block Fission because the feature being tested is currently used only in chrome UI (password manager). I guess that the original issue of this intermittent failure is in the test framework side or test itself.

Thanks. In that case, I will set this bug's Fission Milestone to "Future" so it doesn't block Fission MVP.

Note that this test_cut_copy_password.html test is now disabled for Windows opt builds testing with Fission+xorigin mode:

https://searchfox.org/mozilla-central/rev/5e955a47c4af398e2a859b34056017764e7a2252/editor/libeditor/tests/mochitest.ini#254-256

[test_cut_copy_password.html]
skip-if =
  fission && xorigin && os == "win" && !debug  # Bug 1716408 - New fission platform triage

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1716408 - Make enable `test_cut_copy_password.html` in all cases r=m_kato!

The fix of bug 1676702 made the test stable. So, let's try to enable it in
any environment.

Depends on D118758

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Test result: https://treeherder.mozilla.org/jobs?repo=try&revision=dd34ce791a559e2bf63860205e40b9b3d18ea9ff

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f06e1a7dc651
Make enable `test_cut_copy_password.html` in all cases r=m_kato

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f06e1a7dc651