1716413 - Fix widget/tests/test_mouse_event_with_control_on_mac.html test skipped in 'widget/tests/mochitest.ini' for fission xorigin

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Andrew Halberstadt [:ahal]]

Note: This bug was filed automatically via script.

The following tests are being disabled in widget/tests/mochitest.ini due to new fission xorigin platform triage:

• test_mouse_event_with_control_on_mac.html

Full diff:

diff --git a/widget/tests/mochitest.ini b/widget/tests/mochitest.ini
--- a/widget/tests/mochitest.ini
+++ b/widget/tests/mochitest.ini
@@ -2,14 +2,16 @@
 skip-if = toolkit != 'windows' || headless # headless: Bug 1410525
 [test_actionhint.html]
 [test_assign_event_data.html]
 skip-if = toolkit == "cocoa" || (toolkit == 'android' && debug) || android_version == '24' || (headless && os == "win") # Mac: Bug 933303, Android bug 1285414
 [test_autocapitalize.html]
 [test_keypress_event_with_alt_on_mac.html]
 skip-if = toolkit != "cocoa"
 [test_mouse_event_with_control_on_mac.html]
-skip-if = toolkit != "cocoa"
+skip-if =
+  toolkit != "cocoa"
+  fission && xorigin  # {bug} - New fission platform triage
 [test_picker_no_crash.html]
 skip-if = toolkit != "windows" || e10s # Bug 1267491
 support-files = window_picker_no_crash_child.html
 [test_scrollbar_colors.html]
 skip-if = (os == 'linux' && headless) # bug 1460109

See this try push for failures. If failures are missing, they were
either discovered on a subsequent try push or this bug is invalid.

To run these failures in your own try push, first ensure the patches from bug 1700781
have landed, revert the skip-if annotations, then run:

$ ./mach try fuzzy --rebuild 3 widget/tests/mochitest.ini

Finally use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s).

Disclaimer

Adding new platforms is not an exact science, and in order to get to green and
enable coverage ASAP, we often err on the side of disabling when in doubt. For
this reason, it's possible that the annotation was added in error, is covered
by an existing intermittent, or was fixed sometime between now and when the
annotation was made.

If you believe this is the case here, please feel free to remove the
annotation. Sorry for the inconvenience and thanks for understanding.

Comment 1

[Chris Peterson [:cpeterson]]

Jim, here is a Cocoa widget test failure with Fission (in xorigin mode). Do you think fixing this test failure should block shipping Fission MVP?

The try push linked in comment 0 is out of date. Here is a more recent try push with this test failure:

https://treeherder.mozilla.org/push-health/push?repo=try&revision=81b4bb3d454c71ae5b3e643d64d7a5b670694a55&testGroup=pr&selectedTest=widgetteststestmouseeventwithcontrolonmachtml&selectedTaskId=342391868&selectedJobName=widget%2Ftests%2Ftest_mouse_event_with_control_on_mac.html+test-macosx1015-64-qr%2Fdebug-mochitest-plain-fis-xorig-e10s-1

TEST-UNEXPECTED-FAIL | widget/tests/test_mouse_event_with_control_on_mac.html | Test timed out. -
TEST-UNEXPECTED-FAIL | widget/tests/test_mouse_event_with_control_on_mac.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once. Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!

Comment 2

[Chris Peterson [:cpeterson]]

Stephen, this bug is a "you are leaking the world" leak in macOS test test_mouse_event_with_control_on_mac.html when running in Fission "xorigin" test mode (where the mochitest test runner loads the test case html in a cross-origin iframe).

Do you think fixing this failure should block shipping Fission? Do you have time to investigate this test failure?

To run a test in Fission xorigin mode, use mach mochitest --enable-fission --enable-xorigin-tests.

Comment 3

[Stephen A Pohl [:spohl]]

(In reply to Chris Peterson [:cpeterson] from comment #2)

Stephen, this bug is a "you are leaking the world" leak in macOS test test_mouse_event_with_control_on_mac.html when running in Fission "xorigin" test mode (where the mochitest test runner loads the test case html in a cross-origin iframe).

Do you think fixing this failure should block shipping Fission? Do you have time to investigate this test failure?

I have assigned a priority of P2, which means we're not actively looking into it but it's next on our list (along with other P2 bugs). Unfortunately, I don't expect to have time to investigate it in the near term and this makes it difficult to make a recommendation for Fission.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Stephen A Pohl [:spohl] from comment #3)

(In reply to Chris Peterson [:cpeterson] from comment #2)

Do you think fixing this failure should block shipping Fission? Do you have time to investigate this test failure?

I have assigned a priority of P2, which means we're not actively looking into it but it's next on our list (along with other P2 bugs). Unfortunately, I don't expect to have time to investigate it in the near term and this makes it difficult to make a recommendation for Fission.

Thanks. I understand. I'll keep this bug in Fission's M8 bug list for now, so I can continue to monitor it. We can decide later whether to ship Fission without this test fix.

Comment 5

[Markus Stange [:mstange]]

Edgar, could you look into this test failure?

Comment 6

[Edgar Chen [:edgar]]

I will take a look, taking this bug.

Comment 7

[Edgar Chen [:edgar]]

Attachment: Bug 1716413 - Wait for APZ stable in test_mouse_event_with_control_on_mac.html; r=smaug

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/874e9e2fef72
Wait for APZ stable in test_mouse_event_with_control_on_mac.html; r=smaug

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/874e9e2fef72

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:edgar, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Edgar Chen [:edgar]]

I assume we only run fission-xorigin tests on m-c for now, so probably don't need to uplift to beta?

Comment 12

[Chris Peterson [:cpeterson]]

(In reply to Edgar Chen [:edgar] from comment #11)

I assume we only run fission-xorigin tests on m-c for now, so probably don't need to uplift to beta?

No need to uplift to Beta since this is a test fix.