Remove vendored fxa-client crate and related bridging code
Categories
(Firefox :: Sync, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: rfkelly, Assigned: teshaq)
References
Details
Attachments
(1 file)
In Bug 1631630 we landed Rust client code for the Firefox Accounts service, and some bridging code to expose the Rust APIs to JavaScript. Unfortunately we never finished the work of replacing the current JS FxA client code with this new version, so it's just sitting around in the tree being unused.
We still aspire to replace the JS FxA client code with the shared Rust code, but it's not on our short-term roadmap, and when we do make another attempt at it the details are likely to look pretty different. So, let's remove what we currently have from the tree - it will reduce build time, reduce potential for confusion, and give us a clean slate for when we want to take another crack at this.
Concretely, this will look like undoing the two patches associated with Bug 1631630. I don't expect them to revert cleanly, but a good approach would be to look through the patches from that bug, find the corresponding code in the current tree, and delete or undo the changes piece by piece.
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
Reporter | |
Comment 2•3 years ago
|
||
Thanks Tarik! IIUC you should be all set to land this through Lando, but ping me if you run into any trouble with that process.
Pushed by teshaq@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/97ce4ca4f50b Removes fxa-client rust code from Desktop. r=rfkelly
|
|
Assignee | |
Comment 4•3 years ago
|
||
For future reference when and if we end up adding back the rust fxa-client to desktop, although it will probably look different depending how our vendoring story evolves, but here's what this change entailed:
The majority of the change done in the patch was auto-removal of third-party dependencies initiated using mach vendor rust. Those auto-deleted files were the ones in the third-party directory. Everything else was manually deleted first to counteract the work done in Bug 1631630.
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•